Fix #4138 fix delivery address #4540
Conversation
* group examples together with variables * rubocop -A passes on this file without needing to disable ArrayAlignment
* Compare generated against expected PDFs * Add helper test to regenerate expected PDFs * Add helper module
…ethod * Address output prints delivery address if filled in, otherwise partner address * Only does this for delivery/shipped method
|
Hey @jimmyli97 As a matter of process, in the future please get yourself assigned to the issues when you are going to be working on them - or at least comment on them. This helps us avoid duplication of effort. Thanks. |
|
@cielf it automatically unassigned me, should I keep commenting every 7 days? |
|
Oops - sorry, my bad (I somehow didn't see that you had been assigned and weren't anymore). Not to worry. |
|
But if it's going to lapse while you are still working on it, yeah - commenting makes sense -- otherwise someone else may pick it up. Once you've put in the pull request, it's not as big a deal. |
There was a problem hiding this comment.
Hrm. I tried blanking out the two addresses, and got a mess. This shouldn't happen in real life (if it's being delivered, there really should be a delivery address, but I could see it happening in a situation where the bank is very familiar with a new partner, and some staff drops by the partner with the goods on their way home or something ). I'd still like to see it fixed. (You could suppress the "Delivery address" label in this case too.)
* REFACTOR out profile name and email
cielf
dismissed
their stale review
My concerns have been addressed. Over to @dorner for a technical look-see.
|
Hey @dorner -- it looks like the ball on this one is currently in your court? |
.gitignore
Outdated
| @@ -49,6 +49,7 @@ dump.rdb | |||
| .DS_Store | |||
| .ruby-gemset | |||
| !spec/fixtures/files/*.pdf | |||
There was a problem hiding this comment.
Why are you adding this if you've added these files? Shouldn't they be tracked?
There was a problem hiding this comment.
line 51 tells git to ignore all .pdf files so line 52 specifies an exception (by prefixing an exclamation mark) to track the pdf files in spec/fixtures/files
added a comment to clarify in 0d53723
| compare_pdf(create_dist(:pick_up), expected_pickup_file) | ||
| end | ||
| end | ||
| # this test is a helper function to regenerate expected PDFs, only commit with it skipped |
There was a problem hiding this comment.
That's really confusing. If you want a helper method, why not define it as a method, and people can run it from the Rails console?
There was a problem hiding this comment.
to generate the pdf files correctly, the helper method generating the file needs to have the same test environment setup as the actual test itself. This way you don't have to repeat code setting up the test environment. I did research but I could not figure out a better way to do it without duplicating code.
you can call this method from the terminal by calling the test's line number e.g. bundle exec rspec spec/pdfs/distribution_pdf_spec.rb:227.
I added a comment clarifying this in 0d53723
alternatively I could delete the method if you want, but I found it super helpful because I could just run that line whenever I made changes to the pdf generation and regenerate the test files. so if anyone in the future makes changes they could do the same thing.
There was a problem hiding this comment.
There should definitely be a way to do this without duplicating code. Maybe it's the setup that needs to be extracted to a base method that's called from both places. And worse comes to worst, if you do need to duplicate a few lines of code, it's still a lot less messy than a test that's not actually a test.
Resolves #4138
Description
Prints no address if delivery_method is pick_up
Prints partner address if partner has no program address and delivery_method is delivery or shipped
Prints partner program address if partner has program address and delivery_method is delivery or shipped
Tests output against expected PDFs
Adds helper test to generate expected PDFs
Type of change
How Has This Been Tested?
Passes test suite
Manual testing