Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4486: address pickup email issues #4648

Merged
merged 25 commits into from
Sep 20, 2024
Merged

4486: address pickup email issues #4648

merged 25 commits into from
Sep 20, 2024

Commits on Sep 11, 2024

  1. Add validation on pick_up_email

    @panacotar
    panacotar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    b15db30 View commit details
    Browse the repository at this point in the history

  2. Add specs for pick_up_email validation

    @panacotar
    panacotar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e4ffe4e View commit details
    Browse the repository at this point in the history

  3. fix typo in specs

    @panacotar
    panacotar committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    df4135c View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. update distribution mailer spec to support multiple pick up emails

    @panacotar
    panacotar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ae32e37 View commit details
    Browse the repository at this point in the history

  2. change pick up person to plural

    @panacotar
    panacotar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    7a78bc1 View commit details
    Browse the repository at this point in the history

  3. handle multiple pick up addresses in cc

    @panacotar
    panacotar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    3b32502 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into 4486-address-pickup-email-issues

    @panacotar
    panacotar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    ab1df0a View commit details
    Browse the repository at this point in the history

  5. add another test for pick_up_email validator

    @panacotar
    panacotar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    202efcc View commit details
    Browse the repository at this point in the history

  6. update pick_up_email validator to disregard commas at beginning, end … 

    …of string
    @panacotar
    panacotar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d3dfed5 View commit details
    Browse the repository at this point in the history

  7. flatten the cc array after merging with pick_up_emails

    @panacotar
    panacotar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1389c1d View commit details
    Browse the repository at this point in the history

  8. update test with unique pick up emails

    @panacotar
    panacotar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5be76e1 View commit details
    Browse the repository at this point in the history

  9. not allow repeated pick_up_email addresses

    @panacotar
    panacotar committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    70777ab View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2024

  1. add tests for profile#split_pick_up_emails

    @panacotar
    panacotar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9d3ed3c View commit details
    Browse the repository at this point in the history

  2. add split_pick_up_emails method on Profile model

    @panacotar
    panacotar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    53e98af View commit details
    Browse the repository at this point in the history

  3. update distribution mailer with split_pick_up_emails

    @panacotar
    panacotar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    d21aed3 View commit details
    Browse the repository at this point in the history

  4. update test to use be_valid

    @panacotar
    panacotar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    bd72060 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into 4486-address-pickup-email-issues

    @panacotar
    panacotar committed Sep 13, 2024
    Configuration menu
    Copy the full SHA
    92ac8fb View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2024

  1. remove context wrapper

    @panacotar
    panacotar committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    1fb21ab View commit details
    Browse the repository at this point in the history

  2. add more tests for profile pick_up_emails

    @panacotar
    panacotar committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    f9db471 View commit details
    Browse the repository at this point in the history

  3. fix split_pick_up_emails to handle edge cases

    @panacotar
    panacotar committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    02fb105 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into 4486-address-pickup-email-issues

    @panacotar
    panacotar committed Sep 15, 2024
    Configuration menu
    Copy the full SHA
    463a1f1 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2024

  1. add instructions for comma-separated emails

    @panacotar
    panacotar committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4e4300a View commit details
    Browse the repository at this point in the history

  2. add placeholder to pick_up_email input

    @panacotar
    panacotar committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    91d4db1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into 4486-address-pickup-email-issues

    @panacotar
    panacotar committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    ab7eba7 View commit details
    Browse the repository at this point in the history

  4. change emails label to addresses

    @panacotar
    panacotar committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5bafd76 View commit details
    Browse the repository at this point in the history