Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PULL_REQUEST_TEMPLATE.md #4652

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Update PULL_REQUEST_TEMPLATE.md #4652

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
954b386
Update PULL_REQUEST_TEMPLATE.md
dorner Sep 13, 2024
b7d9e0d
Update PULL_REQUEST_TEMPLATE.md
dorner Sep 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
- I have added tests that prove my fix is effective or that my feature works,
- New and existing unit tests pass locally with my changes ("bundle exec rake"),
- Title include "WIP" if work is in progress.
- I acknowledge that I will *not* force push my branch if any review activity has already happened.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I will not force push my branch once reviews have started.


-->

Expand Down