Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add restriction non negative partner quota #4658

Merged

Conversation

italomatos
Copy link
Contributor

Resolves #4657

Description

Add validation to ensure the quota field is not negative.

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

  • login in as [email protected]
  • From the left hand menu: Partner Agencies | All Partners
  • click on a Partner, then on "Edit Partner Information"
  • Enter a negative number in quota, then "Update Partner".
  • It saves.
  • A validation will appear, preventing saving if it is negative.

Screenshots

image

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Any comments, @dorner?

@italomatos italomatos force-pushed the 4657-restrict-non-negative-partner-quota branch from da4eb0e to 8930b4f Compare September 20, 2024 16:26
@dorner
Copy link
Collaborator

dorner commented Sep 20, 2024

Looks good!

@dorner dorner merged commit 8c6504f into rubyforgood:main Sep 20, 2024
11 checks passed
Copy link
Contributor

@italomatos: Your PR add restriction non negative partner quota is part of today's Human Essentials production release: 2024.09.22.
Thank you very much for your contribution!

jlandiseigsti pushed a commit to jlandiseigsti/human-essentials that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

quota on partner should be restricted to non-negative.
3 participants