Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change profile terminology #4659

Merged
merged 2 commits into from
Sep 15, 2024

Conversation

italomatos
Copy link
Contributor

@italomatos italomatos commented Sep 15, 2024

Resolves #4654

Description

This PR aims to adjust some terms related to the profile.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • A) In the left hand menu for partners (seen when you log in as [email protected]), change "My organization" to "My profile"
  • B) On the bank's view of the partner (log in as [email protected], click on "Partner Agencies", then "All Partners", then click on a specific partner), change "Application & Information" to "Partner Profile".
  • C) Change the "Review application" button in the "All Partners" view to "Review Applicant's Profile"

Screenshots

change "My organization" to "My profile"

image

change "Application & Information" to "Partner Profile"

image

"change Review application" button in the "All Partners" view to "Review Applicant's Profile"

image

@italomatos italomatos force-pushed the 4654-profile-terminology-update branch 3 times, most recently from 05ae987 to 9de4b61 Compare September 15, 2024 19:32
@cielf cielf self-requested a review September 15, 2024 19:48
Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @italomatos -- the screenshots look great! We miscommunicated slightly, though.

"Edit My Organization" on the partner's left hand menu should be "Edit My Profile". Could you make that change too, please?

Thanks!

@italomatos italomatos force-pushed the 4654-profile-terminology-update branch from 1b74aaf to 7c9de72 Compare September 15, 2024 20:09
@italomatos
Copy link
Contributor Author

Hey @italomatos -- the screenshots look great! We miscommunicated slightly, though.

"Edit My Organization" on the partner's left hand menu should be "Edit My Profile". Could you make that change too, please?

Thanks!

Thank you @cielf for reviewing

Copy link
Collaborator

@cielf cielf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cielf cielf merged commit 3963287 into rubyforgood:main Sep 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change user-facing terminology around partner profile to profile
2 participants