Move Transfer.storage_locations_transferred_to/from_in to StorageLoca… #4733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dorner
requested changes
Oct 27, 2024
| @@ -77,6 +77,14 @@ def self.items_inventoried(organization, inventory = nil) | |||
| end | |||
| end | |||
|
|
|||
| def self.with_transfers_to(organization) | |||
| joins(:transfers_to).where(organization_id: organization.id).distinct.order(:name) | |||
There was a problem hiding this comment.
You shouldn't need the where clause since the transfer has a from_id and to_id which powers the association.
There was a problem hiding this comment.
Without the where clause, wouldn't we be grabbing every storage location that has at least one transfer from/to that location? Don't we only want the storage locations related to a certain organization?
There was a problem hiding this comment.
Storage locations belong to an organization and so do transfers. So if you have a transfer, by definition only storage locations belonging to the same organization can be involved in it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Doesn't resolve any issue)
Description
While working on something else, I noticed this
Transferclass method that seemed odd in that it returns an array ofStorageLocationActiveRecord objects. Feels like it belongs more on theStorageLocationmodel. Moving it also simplified the method logic.Also fixed the association's
foreign_keyso that ActiveRecord can join the table correctly.Type of change
Refactor
How Has This Been Tested?
Moved model spec from
TransfertoStorageLocation.