Validate issued_at field to prevent future dates further than 1 year

[tatheerf02]

Resolves #4742

Description

Add a new validation to the issued_at field which is present on the donation, distribution, and purchase models. The new validation ensures that the field can not be set to a date that is further than one year into the future, as this causes unexpected behaviour when the models are later filtered.

An alternative solution could be to add this validation to the models themselves, but putting it in the centralized location was an existing pattern and made more sense.

Tradeoff: Are there valid use cases where we might want to have set this date to further than one year ahead?

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Added new unit tests following existing patterns for all affected models and ensured they passed

Screenshots

Note: Although not pictured, I also tested that the validation is run when the date on a purchase, donation, or distribution is edited after creation.

📸 Validation error shown on new donation

📸 Validation error shown on new purchase

📸 Validation error shown on new distribution

[cielf]

@tatheerf02 Let's change that from "Cannot be further than 1 year" to "cannot be more than 1 year in the future".

[tatheerf02]

Let's change that from "Cannot be further than 1 year" to "cannot be more than 1 year in the future".

@cielf I've changed the error message and updated the screenshots in the description 👍

[cielf]

LGTM from a functional pov; I found an unrelated issue (which is also in main).

[cielf]

I took a glancing look at the code, and I'm not sure all the changes made to the calendar_service_spec are in scope? Passing it to @awwaiid or @dorner for an opinion, and other technical review.

[dorner]

Looks good. The calendar spec had to change because it had a year too far in the future, which would prevent the object from saving now.

[github-actions]

@tatheerf02: Your PR Validate issued_at field to prevent future dates further than 1 year is part of today's Human Essentials production release: 2024.11.03.
Thank you very much for your contribution!