Skip to content

Commit

Permalink
Update to node 23.6.1
Browse files Browse the repository at this point in the history
  • Loading branch information
bnoordhuis committed Jan 31, 2025
1 parent f805e37 commit b234a71
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 13 deletions.
16 changes: 8 additions & 8 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
run: |
bundle exec rake build
- name: Upload gem
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: gem-${{ steps.set-metadata.outputs.GEM_VERSION }}-ruby
path: pkg
Expand Down Expand Up @@ -135,12 +135,12 @@ jobs:
run: |
bundle exec rake binary
- name: Upload V8
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: v8-${{ steps.set-metadata.outputs.LIBV8_VERSION }}-${{ steps.set-metadata.outputs.GEM_PLATFORM }}
path: vendor
- name: Upload gem
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: gem-${{ steps.set-metadata.outputs.GEM_VERSION }}-${{ steps.set-metadata.outputs.GEM_PLATFORM }}
path: pkg
Expand Down Expand Up @@ -274,12 +274,12 @@ jobs:
run: |
docker exec -w "${PWD}" ${{ steps.container.outputs.id }} bundle exec rake binary[${{ steps.platform.outputs.ruby_target_platform }}]
- name: Upload V8
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: v8-${{ steps.set-metadata.outputs.LIBV8_VERSION }}-${{ steps.platform.outputs.ruby_target_platform }}
path: vendor
- name: Upload gem
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: gem-${{ steps.set-metadata.outputs.GEM_VERSION }}-${{ steps.platform.outputs.ruby_target_platform }}
path: pkg
Expand Down Expand Up @@ -327,7 +327,7 @@ jobs:
ruby -e 'puts Gem.platforms.last.to_s' | tee gem_platform
echo "::set-output name=GEM_PLATFORM::$(cat gem_platform)"
- name: Download a single artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: gem-${{ needs.build-ruby.outputs.GEM_VERSION }}-ruby
path: pkg
Expand Down Expand Up @@ -360,7 +360,7 @@ jobs:
ruby -e 'puts Gem.platforms.last.to_s.gsub(/-darwin-?\d+/, "-darwin")' | tee gem_platform
echo "::set-output name=GEM_PLATFORM::$(cat gem_platform)"
- name: Download a single artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: gem-${{ needs.build-darwin.outputs.GEM_VERSION }}-${{ steps.set-metadata.outputs.GEM_PLATFORM }}
path: pkg
Expand Down Expand Up @@ -440,7 +440,7 @@ jobs:
docker exec -w "${PWD}" ${{ steps.container.outputs.id }} ruby -e 'puts Gem::Platform.local.tap { |p| RUBY_PLATFORM =~ /musl/ && p.version.nil? and p.instance_eval { @version = "musl" } }.to_s' | tee gem_platform
echo "::set-output name=GEM_PLATFORM::$(cat gem_platform)"
- name: Download a single artifact
uses: actions/download-artifact@v3
uses: actions/download-artifact@v4
with:
name: gem-${{ needs.build-linux.outputs.GEM_VERSION }}-${{ steps.set-metadata.outputs.GEM_PLATFORM }}
path: pkg
Expand Down
6 changes: 3 additions & 3 deletions lib/libv8/node/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ module Libv8
end

module Libv8::Node
VERSION = '22.13.1.0'
NODE_VERSION = '22.13.1'
LIBV8_VERSION = '12.4.254.21' # from src/node-.../deps/v8/include/v8-version.h
VERSION = '23.6.1.0'
NODE_VERSION = '23.6.1'
LIBV8_VERSION = '12.9.202.28' # from src/node-.../deps/v8/include/v8-version.h
end
1 change: 1 addition & 0 deletions sums/v23.6.1.sum
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
35c0f7957085083071fcf01c7eaea953fba98f17afc4d7c189e3ef56925b453c
4 changes: 2 additions & 2 deletions test/gtest/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
cmake_minimum_required(VERSION 3.14)
project(gtest)

# V8 requires at least C++17
set(CMAKE_CXX_STANDARD 17)
# V8 requires at least C++20
set(CMAKE_CXX_STANDARD 20)

include(FetchContent)
FetchContent_Declare(
Expand Down

0 comments on commit b234a71

Please sign in to comment.