Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to node v17.3.1 #31

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Update to node v17.3.1 #31

merged 2 commits into from
Jan 24, 2022

Conversation

nightpool
Copy link
Contributor

This also includes a performance improvement for the build_monolith.sh script, which is to invoke ar once with all of the libraries to be included, rather then building it incrementally. Because of how ar creates a copy of the archive to update rather then updating the archive file in place, this speeds up the creation of the archive file significantly (When building with debug symbols, build_monolith.sh alone was taking >12 hours, and now takes 30ish minutes).

@lloeki
Copy link
Collaborator

lloeki commented Jan 24, 2022

Thanks for this update @nightpool!

@lloeki
Copy link
Collaborator

lloeki commented Jan 24, 2022

invoke ar once with all of the libraries to be included, rather then building it incrementally

I can't recall why I did that, I think it was when trying to debug some specific symbol missing situations, and then having split ar calls made them appear for some reason.

@lloeki lloeki merged commit ad91055 into rubyjs:master Jan 24, 2022
@nightpool nightpool deleted the v17.3.1 branch January 27, 2022 16:16
@tisba
Copy link

tisba commented Feb 13, 2022

Hey @lloeki. Any plans on releasing a new version yet? Especially #27 would be interesting, since a bunch of mini_racer installation issues are caused by this.

I don't know much about building C/C++ projects, but I'm happy to help where I can (I have Intel and M1 hardware available).

@lloeki
Copy link
Collaborator

lloeki commented Feb 13, 2022

Yup, plans indeed, it's just that I had to pull off some double shifts last month to reach some goals.

So plans are a) recover a bit from that b) build and push missing aarch64 musl lib and a new fat libc+musl c) build and push 17.x d) get aarch64 musl cross compiling sorted out

@SamSaffron
Copy link
Collaborator

@lloeki any chance we can do a release? perhaps we can add @nightpool to the rotation of people who can do the releases to decrease bus factor?

@lloeki
Copy link
Collaborator

lloeki commented Aug 17, 2022

I'm AFK til next week (checking things on phone), I'll do the release then and add @nightpool as suggested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants