Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Update builder.rb to fix getting python2 version on Windows #307

Closed
wants to merge 1 commit into from

Conversation

Ridje
Copy link

@Ridje Ridje commented Nov 18, 2020

With single quote on Win 10 IRB returns:

irb(main):007:0> `python -c 'import platform; print(platform.python_version())'`.chomp
File "", line 1
'import
^
SyntaxError: EOL while scanning string literal

So I can't install libv8 via bundle without additional manipulations.
But it works correctly with double quotes:
irb(main):010:0> python -c "import platform; print(platform.python_version())".chomp => "2.7.6"
I suggest use double quotes here, have checked on Mac
python -c "import platform; print(platform.python_version())" works the same way.

@lloeki
Copy link
Contributor

lloeki commented Dec 4, 2023

Our efforts are focused on libv8-node and thus libv8 is unmaintained, so I'll close this.

Thanks for the contribution!

@lloeki lloeki closed this Dec 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants