Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chimera_http_client to http_clients.yml #871

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

mediafinger
Copy link
Contributor

Only adding a missing gem to the catalog.


Thanks for contributing to the Ruby Toolbox catalog! ❤️

Before submitting your pull request:

  • If you're referencing a gem by its GitHub repository (e.g. rails/rails), please verify
    that it is not packaged as a Ruby gem. (If it is packaged as a gem, please reference it
    by its gem name instead, e.g. rails.)
  • Please make sure the projects are listed in case-insensitive alphabetical order
  • Make sure the CI build passes, we validate your proposed changes in the test suite :)

@mediafinger
Copy link
Contributor Author

mediafinger commented Apr 19, 2024

The test suite fails with an error message that looks unrelated to my changes:

Failures:

  1) Catalog referenced rubygems references only actually existing gems
     Failure/Error: expect(referenced_gems - available_gems).to eq []

       expected: []
            got: ["mongoid-rating"]

And the gem mongoid-rating seems to exist: https://rubygems.org/gems/mongoid_rating so I don't know if I can do anything to fix the tests.

Only adding a missing gem to the catalog.
@colszowka colszowka merged commit c24f76f into rubytoolbox:main Jun 28, 2024
4 checks passed
@colszowka
Copy link
Member

Thank you @mediafinger 👋 , I rebased the branch and everything is fine now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants