Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loosen ordering requirement, add seedie #896

Merged
merged 2 commits into from
Jun 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ Thanks for contributing to the Ruby Toolbox catalog! <3
- [ ] If you're referencing a gem by its GitHub repository (e.g. `rails/rails`), please verify
that it is _not_ packaged as a Ruby gem. (If it _is_ packaged as a gem, please reference it
by its gem name instead, e.g. `rails`.)
- [ ] Please make sure the projects are listed in case-insensitive alphabetical order
- [ ] Make sure the CI build passes, we validate your proposed changes in the test suite :)
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ Each `category.yml` currently contains:

* `name` (string, required): Human display name of the category name
* `description` (string, optional): A (markdown-formatted) category description
* `projects` (array of strings in case-insensitive alphabetical order, required): The list of projects to list in
* `projects` (array of strings, required): The list of projects to list in
that category. For rubygems, this is the plain gem name, for github repos it's
the full repo slug (`github_user/repo_name`). Projects can be listed in multiple
categories.
Expand Down
1 change: 1 addition & 0 deletions catalog/Active_Record_Plugins/rails_db_bootstrapping.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,5 @@ projects:
- seed-fu
- seed_dumper
- seedbank
- seedie
- sevenwire/bootstrapper
5 changes: 2 additions & 3 deletions spec/catalog_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,8 @@

described_class.new.as_json[:category_groups].map { |group| group[:categories] }.flatten.each do |category|
describe "Category #{category['name'].inspect}" do
it "defines all projects in alphabetical order" do
expected_order = category["projects"].sort_by(&:downcase)
expect(category["projects"]).to eq expected_order
it "does not define duplicates" do
expect(category["projects"]).to eq category["projects"].uniq
end
end
end
Expand Down
Loading