Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intuit alternate JSON response #612

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

rchekaluk
Copy link

@rchekaluk rchekaluk commented Jun 23, 2024

I empirically observed an intermittent alternate response when testing TaxService#create against an Intuit sandbox. This PR extends the gem to handle both forms of the response.

Typical Intuit response:

{"Fault":{"Error":[{"Message":"Duplicate Name Exists Error","Detail":"The name supplied already exists. : null","code":"6240"}],"type":"ValidationFault"},"time":"2024-06-23T04:29:11.688-07:00"}

Alternate Intuit response:

{"fault":{"error":[{"message":"Duplicate Name Exists Error","detail":"The name supplied already exists. : null","code":"6240"}],"type":"ValidationFault"},"batchItemResponse":[],"attachableResponse":[],"time":1719142418269,"cdcresponse":[]}

(note: the PR additionally adds a small workaround to make test cases pass)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant