Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unmarshalling info and config #17

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix: unmarshalling info and config #17

merged 1 commit into from
Sep 6, 2023

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Sep 6, 2023 •
edited
Loading

Description

  • We are getting mixed output either Array or Multi-line JSON when doing docker inspect or ps.
  • So trying to unmarshall to Array first. If it is successful, then return. If not, then try to parse each JSON object and unmarshal it.

Notion Ticket

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@achettyiitr achettyiitr requested a review from lvrach September 6, 2023 16:36
@achettyiitr achettyiitr changed the title fix: unmarshall infor and config fix: unmarshalling during info and config Sep 6, 2023
@achettyiitr achettyiitr changed the title fix: unmarshalling during info and config fix: unmarshalling info and config Sep 6, 2023
@achettyiitr achettyiitr merged commit 23bd2c4 into main Sep 6, 2023
10 of 11 checks passed
@achettyiitr achettyiitr deleted the fix.unmarshall branch September 6, 2023 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvrach lvrach lvrach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achettyiitr @lvrach