fix: workspace config connection as map instead of slice #12
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
=======================================
Coverage 97.74% 97.74%
=======================================
Files 7 7
Lines 177 177
=======================================
Hits 173 173
Misses 4 4 ☔ View full report in Codecov by Sentry. |
| @@ -16,7 +16,7 @@ type WorkspaceConfig struct { | |||
| Settings *Settings `json:"settings"` | |||
| Sources map[string]*Source `json:"sources"` | |||
| Destinations map[string]*Destination `json:"destinations"` | |||
| Connections []*Connection `json:"connections"` | |||
| Connections map[string]*Connection `json:"connections"` | |||
There was a problem hiding this comment.
@fxenik do you think we can come up with a way to test these? an integration test perhaps?
There was a problem hiding this comment.
If we are spending any effort on testing these automatically, I think we should do it in a way that makes sense for the whole org. We should resume the work for provisioning a disposable control plane and then write integration tests for the SDK to ensure it is retrieving/parsing data correctly. I'll have a chat with Sumanth today to see how we can find bandwidth for that.
There was a problem hiding this comment.
Approved with the plan to revisit with kind once we got the helm charts working.
@achettyiitr can you create a task for the follow up please?
https://linear.app/rudderstack/issue/PIPE-734/integration-tests-using-kind-for-cp-sdk |
Description
Linear Ticket
Security