Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove subscriber #16

Merged
merged 1 commit into from
Jan 31, 2024
Merged

chore: remove subscriber #16

merged 1 commit into from
Jan 31, 2024

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Jan 31, 2024

Description

  • Since (cp *ControlPlane) Subscribe() return something, it need to be exported. Currently, it's returning *cache.Subscriber which is internal.
  • Since the Subscriber struct, currently does not add much of a value, removing it.

Linear Ticket

  • Resolves PIPE-715

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (18b146c) 97.74% compared to head (2da0dec) 97.67%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   97.74%   97.67%   -0.07%     
==========================================
  Files           7        6       -1     
  Lines         177      172       -5     
==========================================
- Hits          173      168       -5     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr merged commit 4adc6cf into main Jan 31, 2024
10 checks passed
@achettyiitr achettyiitr deleted the chore.rem-subscriber branch January 31, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants