Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: poc #3

Closed
wants to merge 23 commits into from
Closed

chore: poc #3

wants to merge 23 commits into from

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Jan 3, 2024

Description of the change

  • POC.

fxenik and others added 7 commits August 1, 2023 13:16
* Split workspace config model to multiple files
* Explicitly name model version in package
* Renamed SDK to Control Plane
* Refactored sample app for best practices
* Used url.URL to configure base URL for better error handling
* Split workspace config model to multiple files
* Explicitly name model version in package
* Renamed SDK to Control Plane
* Refactored sample app for best practices
* Used url.URL to configure base URL for better error handling
@achettyiitr achettyiitr marked this pull request as draft January 3, 2024 19:39
@achettyiitr achettyiitr changed the base branch from poller to main January 4, 2024 09:41
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4adc6cf) 97.67% compared to head (45e5960) 97.77%.
Report is 3 commits behind head on main.

❗ Current head 45e5960 differs from pull request most recent head ceb8b5d. Consider uploading reports for the commit ceb8b5d to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
+ Coverage   97.67%   97.77%   +0.10%     
==========================================
  Files           6        7       +1     
  Lines         172      180       +8     
==========================================
+ Hits          168      176       +8     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr changed the base branch from main to chore.mod-name-cp-sdk January 31, 2024 07:11
@achettyiitr achettyiitr changed the title chore: poc chore: decouple cache and subscriber Jan 31, 2024
@achettyiitr achettyiitr changed the title chore: decouple cache and subscriber chore: poc Jan 31, 2024
Base automatically changed from chore.mod-name-cp-sdk to main January 31, 2024 14:53
@achettyiitr achettyiitr force-pushed the chore.poc branch 4 times, most recently from 45e5960 to e5d2953 Compare February 1, 2024 08:15
@achettyiitr achettyiitr force-pushed the chore.poc branch 2 times, most recently from 031d80b to e4b99c1 Compare February 1, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants