Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update endpoint to new ha service #44

Merged
merged 2 commits into from
Jun 7, 2024
Merged

feat: update endpoint to new ha service #44

merged 2 commits into from
Jun 7, 2024

Conversation

aris1009
Copy link
Member

@aris1009 aris1009 commented Jun 6, 2024

Description

  • add new base URL for namespace http client
  • modify namespace URL path to fetch configs from new HA service

Linear Ticket

https://linear.app/rudderstack/issue/CP-2587/[control-plane-sdk]-update-namespace-endpoint

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@aris1009 aris1009 requested review from fracasula and achettyiitr June 6, 2024 09:41
@aris1009 aris1009 self-assigned this Jun 6, 2024
@aris1009 aris1009 force-pushed the feature/cp-2587-control-plane-sdk-update-namespace-endpoint branch 2 times, most recently from a735a1f to 28f7ee3 Compare June 6, 2024 10:21
@aris1009 aris1009 changed the title feat(http-client)!: update endpoint to new ha service feat!: update endpoint to new ha service Jun 6, 2024
@aris1009 aris1009 force-pushed the feature/cp-2587-control-plane-sdk-update-namespace-endpoint branch from 28f7ee3 to 982eb2b Compare June 6, 2024 11:32
@achettyiitr achettyiitr changed the title feat!: update endpoint to new ha service feat: update endpoint to new ha service Jun 7, 2024
@aris1009 aris1009 merged commit 06ecef1 into main Jun 7, 2024
7 checks passed
@aris1009 aris1009 deleted the feature/cp-2587-control-plane-sdk-update-namespace-endpoint branch June 7, 2024 06:09
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achettyiitr achettyiitr achettyiitr approved these changes

@fracasula fracasula Awaiting requested review from fracasula

Assignees

@aris1009 aris1009

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aris1009 @achettyiitr