Merge pull request #35 from rudderlabs/release/3.3.0

chore(release): pulling release/3.3.0 into master

.github/workflows/draft_new_release.yml

@@ -73,4 +73,4 @@ jobs:
           github_token: ${{ secrets.PAT }}
           pr_title: "chore(release): pulling ${{ steps.create-release.outputs.branch_name }} into master"
           pr_body:  ":crown: *An automated PR*"
-          pr_reviewer: 'itsdebs'
+          pr_reviewer: "@rudderlabs/sdk-android"

CHANGELOG.md

@@ -2,6 +2,13 @@
 
 All notable changes to this project will be documented in this file. See [standard-version](https://github.com/conventional-changelog/standard-version) for commit guidelines.
 
+## [3.3.0](https://github.com/rudderlabs/rudder-integration-firebase-android/compare/v3.2.0...v3.3.0) (2025-01-13)
+
+
+### Features
+
+* replace hyphen (`-`) with underscore (`_`) present in the event name and its properties, and also in the identify event traits ([003f5af](https://github.com/rudderlabs/rudder-integration-firebase-android/commit/003f5af922dd208d2b0b84079d8d83774c075d33))
+
 ## 3.2.0 (2024-11-05)
 
 

CODEOWNERS

@@ -1 +1 @@
-* @ChryssaAliferi @itsdebs
+* @rudderlabs/sdk-android

firebase/src/main/java/com/rudderstack/android/integration/firebase/Utils.java

@@ -100,7 +100,7 @@ static Map<String, String> transformUserTraits(Map<String, Object> userTraits) {
     }
 
     static String getTrimKey(String key) {
-        String firebaseEvent = key.toLowerCase().trim().replace(" ", "_");
+        String firebaseEvent = key.toLowerCase().trim().replace(" ", "_").replace("-", "_");
         if (firebaseEvent.length() > 40) {
             firebaseEvent = firebaseEvent.substring(0, 40);
         }

gradle.properties

@@ -12,10 +12,10 @@ POM_NAME=Rudder-Integration-Firebase-Android
 POM_DESCRIPTION=RudderStack\'s Native SDK Integration support for Firebase.
 GROUP=com.rudderstack.android.integration
 POM_LICENCE_DIST=repo
-VERSION_NAME=3.2.0
+VERSION_NAME=3.3.0
 POM_LICENCE_NAME=The MIT License (MIT)
 POM_DEVELOPER_NAME=Rudderstack, Inc.
-VERSION_CODE=13
+VERSION_CODE=14
 POM_URL=https://github.com/rudderlabs/rudder-integration-firebase-android
 POM_SCM_URL=https://github.com/rudderlabs/rudder-integration-firebase-android/tree/master
 POM_SCM_CONNECTION=scm:git:git://github.com/rudderlabs/rudder-integration-firebase-android.git

package.json

@@ -1,5 +1,5 @@
 {
-  "version": "3.2.0",
+  "version": "3.3.0",
   "dependencies": {
     "properties-reader": "^2.2.0"
   }

sample-kotlin/src/main/java/com/rudderstack/android/sample/kotlin/MainActivity.kt

@@ -107,6 +107,7 @@ class MainActivity : AppCompatActivity() {
         // Inserting Array types into Traits
         traits.put("intArr", arr)
         traits.put("justArr", justArr)
+        traits.put("key-with-hyphen", "value with hyphen")
         // Inserting Object Types into Traits
         MainApplication.rudderClient.identify("user_id_4", traits, null)
     }
@@ -335,6 +336,11 @@ class MainActivity : AppCompatActivity() {
             "Track event with properties",
             getCustomProperties()
         )
+
+        MainApplication.rudderClient.track(
+            "Track-event-with-hyphen",
+            getCustomProperties()
+        )
     }
 
     // Screen events
@@ -350,6 +356,11 @@ class MainActivity : AppCompatActivity() {
             "Screen event with properties",
             getCustomProperties()
         )
+
+        MainApplication.rudderClient.track(
+            "Screen-event-with-hyphen",
+            getCustomProperties()
+        )
     }
 
     private fun getCustomProperties(): RudderProperty =
@@ -359,4 +370,5 @@ class MainActivity : AppCompatActivity() {
             .putValue("key2", 100)
             .putValue("key3", 200.25)
             .putValue("key4", true)
+            .putValue("key-with-hyphen", "value with hyphen")
 }