Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ga4 update fro server container url #1593

Closed
wants to merge 3 commits into from
Closed

feat: ga4 update fro server container url #1593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a502e39
feat: onboard serber side container URL for GA4
utsabc Jul 31, 2024
16a9576
feat: fix the section
utsabc Jul 31, 2024
1f5d169
feat: update UI sections
utsabc Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/configurations/destinations/ga4/db-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,8 @@
"oneTrustCookieCategories",
"ketchConsentPurposes",
"consentManagement",
"sdkBaseUrl"
"sdkBaseUrl",
"serverContainerUrl"
],
"excludeKeys": [],
"supportedSourceTypes": [
Expand Down Expand Up @@ -70,7 +71,8 @@
"piiPropertiesToIgnore",
"oneTrustCookieCategories",
"ketchConsentPurposes",
"sdkBaseUrl"
"sdkBaseUrl",
"serverContainerUrl"
],
"web": [
"debugView",
Expand Down
73 changes: 48 additions & 25 deletions src/configurations/destinations/ga4/ui-config.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,30 +38,6 @@
],
"default": "gtag"
},
{
"type": "textInput",
"preRequisites": {
"fields": [
{
"configKey": "connectionMode.web",
"value": "device"
},
{
"configKey": "connectionMode.web",
"value": "hybrid"
}
],
"condition": "or"
},
"label": "SDK Base URL",
"configKey": "sdkBaseUrl",
"regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|(?!.*\\.ngrok\\.io)^(?:http(s)?:\\/\\/)?[\\w.-]+(?:\\.[\\w\\.-]+)+[\\w\\-\\._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]*|^$",
"regexErrorMessage": "Please input a valid URL.",
"note": "Enter your GA4 SDK base URL, https://{SDK Base URL}/gtag/js. By default, it is https://www.googletagmanager.com.",
"placeholder": "e.g: https://www.example.com",
"default": "https://www.googletagmanager.com",
"secret": false
},
{
"type": "textInput",
"preRequisites": {
Expand Down Expand Up @@ -130,8 +106,55 @@
"icon": "settings",
"groups": [
{
"title": "GA4 IT",
"title": "GA4 Additional Settings",
"fields": [
{
"type": "textInput",
"preRequisites": {
"fields": [
{
"configKey": "connectionMode.web",
"value": "device"
},
{
"configKey": "connectionMode.web",
"value": "hybrid"
}
],
"condition": "or"
},
"label": "SDK Base URL",
"configKey": "sdkBaseUrl",
"regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|(?!.*\\.ngrok\\.io)^(?:http(s)?:\\/\\/)?[\\w.-]+(?:\\.[\\w\\.-]+)+[\\w\\-\\._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]*|^$",
"regexErrorMessage": "Please input a valid URL.",
"note": "Enter your GA4 SDK base URL, https://{SDK Base URL}/gtag/js. By default, it is https://www.googletagmanager.com.",
"placeholder": "e.g: https://www.example.com",
"default": "https://www.googletagmanager.com",
"secret": false
},
{
"type": "textInput",
"preRequisites": {
"fields": [
{
"configKey": "connectionMode.web",
"value": "device"
},
{
"configKey": "connectionMode.web",
"value": "hybrid"
}
],
"condition": "or"
},
"label": "Server Side Container URL",
"configKey": "serverContainerUrl",
"regex": "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|(?!.*\\.ngrok\\.io)^(?:http(s)?:\\/\\/)?[\\w.-]+(?:\\.[\\w\\.-]+)+[\\w\\-\\._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]*|^$",
"regexErrorMessage": "Please input a valid URL.",
"note": "Enter your GA4 Server Side Container URL, https://{Server Side Container URL}/gtag/js. By default, it is https://analytics.example.com.",
"placeholder": "e.g: https://analytics.example.com",
"secret": false
},
{
"type": "checkbox",
"label": "Debug via Validation Server",
Expand Down
Loading