Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sdk 400 ensure empty key is not accepted as encryption key for #293

Merged
merged 4 commits into from
Sep 4, 2023
Merged

fix: sdk 400 ensure empty key is not accepted as encryption key for #293

merged 4 commits into from
Sep 4, 2023

Conversation

itsdebs
Copy link
Contributor

@itsdebs itsdebs commented Aug 30, 2023

Fixes # (issue)
Null or empty encryption key is not valid anymore. In case of null or empty key, the database is no longer encrypted.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@itsdebs itsdebs requested a review from pallabmaiti as a code owner August 30, 2023 10:24
pallabmaiti
pallabmaiti previously approved these changes Aug 30, 2023
View reviewed changes
@desusai7 desusai7 self-requested a review September 4, 2023 07:13
@sonarcloud
Copy link

sonarcloud bot commented Sep 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@itsdebs itsdebs requested a review from pallabmaiti September 4, 2023 10:12
@itsdebs itsdebs merged commit a7176b1 into develop Sep 4, 2023
7 checks passed
@itsdebs itsdebs deleted the fix/sdk-400-ensure-empty-key-is-not-accepted-as-encryption-key-for branch September 4, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1abhishekpandey 1abhishekpandey 1abhishekpandey approved these changes

@pallabmaiti pallabmaiti pallabmaiti approved these changes

@desusai7 desusai7 Awaiting requested review from desusai7

Assignees

@itsdebs itsdebs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsdebs @pallabmaiti @1abhishekpandey