Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: typo in sample-kotlin build.gradle #337

Merged
merged 1 commit into from
Oct 12, 2023
Merged

fix: typo in sample-kotlin build.gradle #337

merged 1 commit into from
Oct 12, 2023

Conversation

ChryssaAliferi
Copy link
Contributor

Bugfix

This PR fixes a bug in the sample-kotlin app of the rudder-sdk-android project and in which the sample-kotlin app could not being built because of a typo change in the build.gradle build config properties.

The change replaces ' to " in order to be compiled correctly regardless JAVA versions.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@ChryssaAliferi ChryssaAliferi self-assigned this Oct 6, 2023
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ChryssaAliferi ChryssaAliferi added the bug Something isn't working label Oct 6, 2023
@ChryssaAliferi ChryssaAliferi requested review from 1abhishekpandey and removed request for pallabmaiti October 12, 2023 07:26
@ChryssaAliferi ChryssaAliferi merged commit 78a08d8 into develop Oct 12, 2023
@ChryssaAliferi ChryssaAliferi deleted the fix/typo-in-sample-kotlin-build-gradle branch October 12, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1abhishekpandey 1abhishekpandey 1abhishekpandey approved these changes

@itsdebs itsdebs itsdebs approved these changes

Assignees

@ChryssaAliferi ChryssaAliferi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChryssaAliferi @itsdebs @1abhishekpandey