Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keep string literals to refrain from getting obfuscated by dexguard #339

Merged
merged 1 commit into from
Oct 16, 2023
Merged

fix: keep string literals to refrain from getting obfuscated by dexguard #339

merged 1 commit into from
Oct 16, 2023

Conversation

itsdebs
Copy link
Contributor

@itsdebs itsdebs commented Oct 14, 2023

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@itsdebs itsdebs requested a review from pallabmaiti as a code owner October 14, 2023 14:20
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@itsdebs itsdebs merged commit 9d2f5e3 into develop-v2 Oct 16, 2023
@itsdebs itsdebs deleted the fix/sdk-759-fix-dexguarded-string-literal branch October 16, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desusai7 desusai7 desusai7 approved these changes

@ChryssaAliferi ChryssaAliferi ChryssaAliferi approved these changes

@pallabmaiti pallabmaiti Awaiting requested review from pallabmaiti

Assignees

@itsdebs itsdebs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@itsdebs @ChryssaAliferi @desusai7