Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to configure dataPlaneUrl as the metrics url #471

Conversation

1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented Aug 13, 2024

Description

  • Add the option to configure dataPlaneUrl as the metrics URL and remove the default metric URL.
  • Bump and fix the rudderreporter to 0.6.0.
  • Fix the gsonrudderadapter to 0.2.0. (There is no change. We just fixed it to a particular version.)

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@1abhishekpandey 1abhishekpandey self-assigned this Aug 13, 2024
Both rudderreporter and gsonrudderadapter.
Copy link

@1abhishekpandey 1abhishekpandey marked this pull request as ready for review August 20, 2024 22:24
@1abhishekpandey 1abhishekpandey requested a review from a team as a code owner August 20, 2024 22:24
// implementation(project(path: ':gsonrudderadapter'))
implementation 'com.rudderstack.kotlin.sdk:gsonrudderadapter:[0.2.0, 0.3.0)'
implementation 'com.rudderstack.android.sdk:rudderreporter:0.6.0'
implementation 'com.rudderstack.kotlin.sdk:gsonrudderadapter:0.2.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@1abhishekpandey 1abhishekpandey merged commit f0d3ef1 into develop Aug 27, 2024
13 checks passed
@1abhishekpandey 1abhishekpandey deleted the feature/v1/sdk-2187-change-the-url-to-the-correct-based-on-infra-changes-android branch August 27, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants