Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change the metrics endpoint to rsaMetrics #472

Conversation

1abhishekpandey
Copy link
Contributor

@1abhishekpandey 1abhishekpandey commented Aug 13, 2024

Description

  • In this PR, we've updated the metrics endpoint from sdkmetrics to rsaMetrics.
  • The PR reviewer has also been updated.
  • CI: Updated build and test executors in all modules.
  • CI: Exclude all modules from releasing except repository and rudderreporter. These change has been done for release (Changelog generation), release:github (Push GitHub releases), release:sonatype (Releasing the affected packages to sonatype) and release-snapshot:sonatype (Releasing snapshot versions to sonatype).

NOTE: Instead of the next minor version 0.5.0, we need to release these changes in version 0.6.0, as the v1 SDK depends upon [0.4.0, 0.6.0). So if we release it as 0.5.0, it might cause an issue. Therefore, I've manually created and pushed [email protected] tag (this is based on master-v2).

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • Version upgraded (project, README, gradle, podspec etc)
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

@1abhishekpandey 1abhishekpandey self-assigned this Aug 13, 2024
Copy link

@1abhishekpandey 1abhishekpandey marked this pull request as ready for review August 20, 2024 07:59
@1abhishekpandey 1abhishekpandey merged commit 8b879d5 into develop-v2 Aug 20, 2024
12 checks passed
@1abhishekpandey 1abhishekpandey deleted the feature/v2/sdk-2187-change-the-url-to-the-correct-based-on-infra-changes-android branch August 20, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants