chore: review comment address

rudderlabs · Jul 18, 2024 · 017be47 · 017be47
1 parent 0651b04
commit 017be47
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 13 deletions.
diff --git a/packages/analytics-js-plugins/__tests__/errorReporting/index.test.ts b/packages/analytics-js-plugins/__tests__/errorReporting/index.test.ts
@@ -119,11 +119,4 @@ describe('Plugin - ErrorReporting', () => {
 
     expect(state.reporting.breadcrumbs.value.length).toBe(breadcrumbLength + 1);
   });
-
-  it('should not add a new breadcrumb if the message is missing', () => {
-    const breadcrumbLength = state.reporting.breadcrumbs.value.length;
-    ErrorReporting().errorReporting.breadcrumb({}, undefined, undefined, undefined, state);
-
-    expect(state.reporting.breadcrumbs.value.length).not.toBe(breadcrumbLength + 1);
-  });
 });
diff --git a/packages/analytics-js-plugins/src/errorReporting/index.ts b/packages/analytics-js-plugins/src/errorReporting/index.ts
@@ -44,9 +44,9 @@ const ErrorReporting = (): ExtensionPlugin => ({
       pluginEngine: IPluginEngine,
       externalSrcLoader: IExternalSrcLoader,
       logger?: ILogger,
-      flag?: boolean,
+      isInvokedFromLatestCore?: boolean,
     ) => {
-      if (flag) {
+      if (isInvokedFromLatestCore) {
         return undefined;
       }
       if (!state.source.value?.config || !state.source.value?.id) {
@@ -118,9 +118,6 @@ const ErrorReporting = (): ExtensionPlugin => ({
       state?: ApplicationState,
       metaData?: BreadcrumbMetaData,
     ): void => {
-      if (!message) {
-        return;
-      }
       if (state) {
         state.reporting.breadcrumbs.value = [
           ...state.reporting.breadcrumbs.value,

diff --git a/packages/analytics-js/src/services/ErrorHandler/ErrorHandler.ts b/packages/analytics-js/src/services/ErrorHandler/ErrorHandler.ts
@@ -207,7 +207,7 @@ class ErrorHandler implements IErrorHandler {
   notifyError(error: SDKError, errorState: ErrorState) {
     if (this.pluginEngine && isAllowedToBeNotified(error)) {
       try {
-        this.pluginEngine?.invokeSingle(
+        this.pluginEngine.invokeSingle(
           'errorReporting.notify',
           this.pluginEngine, // deprecated parameter
           this.errReportingClient, // deprecated parameter