Skip to content

Commit

Permalink
chore: update code owners for easier release management (#1894)
Browse files Browse the repository at this point in the history
* chore: update code owners for easier release management

* chore: add slash to directories to apply the changes to all

* chore: pass env correctly to npm

* chore: use cross-env

* chore: try direct commit hash

* chore: specify head commit too

* chore: use env now

* chore: move base ref to global env

* chore: check for affected projects

* chore: fix all the workflows

* chore: skip fixing workflows for now

* chore: fix affected issues
  • Loading branch information
saikumarrs authored Oct 21, 2024
1 parent 84bf149 commit 2365e1c
Show file tree
Hide file tree
Showing 5 changed files with 40 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:

env:
NODE_OPTIONS: "--no-warnings"
BASE_REF: ${{ github.event.pull_request.base.sha || 'HEAD' }}

jobs:
bundle-size-checks:
Expand Down Expand Up @@ -64,15 +65,11 @@ jobs:
npm run check:duplicates
- name: Build the project
env:
BASE_REF: ${{ github.event.pull_request.base.sha }}
run: |
npm run build:ci
npm run build:modern:ci
- name: Execute package linting checks
env:
BASE_REF: ${{ github.event.pull_request.base.sha }}
run: |
npm run check:pub:ci
Expand Down
12 changes: 8 additions & 4 deletions .github/workflows/unit-tests-and-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ on:

env:
NODE_OPTIONS: "--no-warnings"
BASE_REF: ${{ github.event.pull_request.base.sha || 'HEAD' }}

jobs:
test:
Expand All @@ -35,9 +36,14 @@ jobs:
run: |
npm run setup:ci
- name: Check for affected projects
id: check_affected
run: |
AFFECTED_PROJECTS=$(npx nx show projects --affected --base=$BASE_REF | tr '\n' ',')
echo "Affected projects: $AFFECTED_PROJECTS"
echo "affected_projects=$AFFECTED_PROJECTS" >> $GITHUB_OUTPUT
- name: Execute unit tests
env:
BASE_REF: ${{ github.event.pull_request.base.sha || 'HEAD' }}
run: |
npm run test:ci
Expand All @@ -49,8 +55,6 @@ jobs:
files: ./packages/analytics-js/reports/coverage/clover.xml,./packages/analytics-js-common/reports/coverage/clover.xml,./packages/analytics-js-integrations/reports/coverage/clover.xml,./packages/analytics-js-plugins/reports/coverage/clover.xml,./packages/analytics-js-service-worker/reports/coverage/clover.xml,./packages/analytics-v1.1/reports/coverage/clover.xml,./packages/analytics-js-cookies/reports/coverage/clover.xml

- name: Execute linting check
env:
BASE_REF: ${{ github.event.pull_request.base.sha || 'HEAD' }}
run: |
npm run check:lint:ci
Expand Down
13 changes: 11 additions & 2 deletions CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
@@ -1,3 +1,12 @@
* @rudderlabs/js-sdk
/packages/analytics-js-integrations/ @rudderlabs/js-sdk-dm-intg-eng
/packages/analytics-js-common/src/constants/integrations @rudderlabs/js-sdk-dm-intg-eng

/packages/analytics-js-integrations/src/ @rudderlabs/js-sdk-dm-intg-eng
/packages/analytics-js-integrations/__fixtures__/ @rudderlabs/js-sdk-dm-intg-eng
/packages/analytics-js-integrations/__tests__/ @rudderlabs/js-sdk-dm-intg-eng
/packages/analytics-js-integrations/__mocks__/ @rudderlabs/js-sdk-dm-intg-eng
/packages/analytics-js-integrations/README.md @rudderlabs/js-sdk-dm-intg-eng
/packages/analytics-js-integrations/.size-limit.js @rudderlabs/js-sdk-dm-intg-eng

/packages/analytics-js-common/src/constants/integrations/ @rudderlabs/js-sdk-dm-intg-eng
/assets/integrations/AdobeAnalytics/ @rudderlabs/js-sdk-dm-intg-eng
/examples/integrations/ @rudderlabs/js-sdk-dm-intg-eng
19 changes: 19 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@
"commitizen": "4.3.1",
"commitlint": "19.5.0",
"core-js": "3.38.1",
"cross-env": "7.0.3",
"dotenv": "16.4.5",
"each": "2.7.0",
"eslint": "8.57.0",
Expand Down

0 comments on commit 2365e1c

Please sign in to comment.