Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Amplitude): update amplitude SDK #1228

Merged
merged 12 commits into from
Sep 28, 2023
Merged

Conversation

ItsSudip
Copy link
Member

PR Description

We are running an old version of amplitude sdk. With this pr, we are updating amplitude SDK to the latest version.

Notion ticket

https://www.notion.so/rudderstacks/d5d15ce4be354e3caae11d4ea9f41477?v=2ad23dce1aeb431a82f783e6607d3cb0&p=8205bf31bc48478ab1475b716b15429b&pm=c

Screenshots

Please add screenshots for any new features or UI bug fixes for the following browsers -

  • Chrome
  • Firefox
  • Safari

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@github-actions
Copy link

github-actions bot commented Jul 20, 2023

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Core - CDN 36.71 KB 36.71 KB (0%) 40.14 KB
All Integrations - CDN 442.54 KB 437.77 KB (-1.08% ▼) 443.55 KB
Core - NPM 36.66 KB 36.66 KB (0%) 40.14 KB
Service Worker - NPM 27.8 KB 27.8 KB (0%) 27.83 KB

@anantjain45823 anantjain45823 self-requested a review August 9, 2023 08:33
anantjain45823
anantjain45823 previously approved these changes Aug 9, 2023
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@MoumitaM MoumitaM merged commit c04ef53 into production-staging Sep 28, 2023
7 checks passed
@MoumitaM MoumitaM deleted the feat.updateAM-SDK branch September 28, 2023 11:43
ItsSudip added a commit that referenced this pull request Sep 29, 2023
* feat(Amplitude): update amplitude SDK (#1228)

* feat(Amplitude): update amplitude SDK

* feat: update logEvent to track

* update mobile and web sdk common fields

* update default value of trackNewCampaigns

* update default eventUploadPeriodMillis to 1000

---------

Co-authored-by: George Bardis <[email protected]>

* feat(analytics-js-integrations): add test of IE11

---------

Co-authored-by: Sudip Paul <[email protected]>
Co-authored-by: ItsSudip <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants