Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sendinblue): improve error message #1357

Merged
merged 3 commits into from
Sep 1, 2023
Merged

chore(sendinblue): improve error message #1357

merged 3 commits into from
Sep 1, 2023

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Aug 31, 2023 •
edited
Loading

PR Description

Resolves INT-451

Notion ticket

Ticket link

Screenshots

Please add screenshots for any new features or UI bug fixes for the following browsers -

  • Chrome
  • Firefox
  • Safari

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@Gauravudia Gauravudia self-assigned this Aug 31, 2023
@github-actions
Copy link

github-actions bot commented Aug 31, 2023 •
edited
Loading

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Core - CDN 36.6 KB 36.6 KB (0%) 40.04 KB ✅
All Integrations - CDN 432.25 KB 432.21 KB (-0.01% ▼) 433.2 KB ✅
Core - NPM 36.54 KB 36.54 KB (0%) 39.94 KB ✅
Service Worker - NPM 27.8 KB 27.8 KB (0%) 27.83 KB ✅

@Gauravudia Gauravudia requested a review from MoumitaM August 31, 2023 11:03
@sonarcloud
Copy link

sonarcloud bot commented Aug 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Gauravudia Gauravudia merged commit 4d5ffaa into production-staging Sep 1, 2023
7 checks passed
@Gauravudia Gauravudia deleted the chore/sendinblue-improve-error-message branch September 1, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihir-4116 mihir-4116 mihir-4116 approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@anantjain45823 anantjain45823 anantjain45823 approved these changes

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

@sandeepdsvs sandeepdsvs Awaiting requested review from sandeepdsvs

@MoumitaM MoumitaM Awaiting requested review from MoumitaM

Assignees

@Gauravudia Gauravudia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gauravudia @anantjain45823 @ItsSudip @mihir-4116