Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(INT-580): object.formEntries is not a function #1365

Merged
merged 2 commits into from
Sep 8, 2023
Merged

fix(INT-580): object.formEntries is not a function #1365

merged 2 commits into from
Sep 8, 2023

Conversation

mihir-4116
Copy link
Contributor

PR Description

  • fixed bugsnag alert related to GA4

Notion ticket

Ticket link

Screenshots

Please add screenshots for any new features or UI bug fixes for the following browsers -

  • Chrome
  • Firefox
  • Safari

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

@mihir-4116 mihir-4116 added the Ready for review Changes are ready to be reviewed label Sep 8, 2023
@mihir-4116 mihir-4116 self-assigned this Sep 8, 2023
@github-actions
Copy link

github-actions bot commented Sep 8, 2023 •
edited
Loading

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Core - CDN 36.71 KB 36.71 KB (0%) 40.14 KB ✅
All Integrations - CDN 435.74 KB 435.5 KB (-0.06% ▼) 436.82 KB ✅
Core - NPM 36.66 KB 36.66 KB (0%) 40.14 KB ✅
Service Worker - NPM 27.8 KB 27.8 KB (0%) 27.83 KB ✅

saikumarrs
saikumarrs previously approved these changes Sep 8, 2023
View reviewed changes
shrouti1507
shrouti1507 previously approved these changes Sep 8, 2023
View reviewed changes
@mihir-4116 mihir-4116 changed the title fix(ga4): object.formEntries is not a function fix(INT-580): object.formEntries is not a function Sep 8, 2023
ItsSudip
ItsSudip previously approved these changes Sep 8, 2023
View reviewed changes
sandeepdsvs
sandeepdsvs previously approved these changes Sep 8, 2023
View reviewed changes
bardisg
bardisg previously approved these changes Sep 8, 2023
View reviewed changes
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.5% 89.5% Coverage
0.0% 0.0% Duplication

@mihir-4116 mihir-4116 merged commit 2f2c3ff into production-staging Sep 8, 2023
12 checks passed
@mihir-4116 mihir-4116 deleted the fix.bugsnag_alert branch September 8, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bardisg bardisg bardisg approved these changes

@shrouti1507 shrouti1507 shrouti1507 approved these changes

@MoumitaM MoumitaM Awaiting requested review from MoumitaM

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

@sandeepdsvs sandeepdsvs Awaiting requested review from sandeepdsvs

@saikumarrs saikumarrs Awaiting requested review from saikumarrs

Assignees

@mihir-4116 mihir-4116

Labels
bug fix Ready for review Changes are ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mihir-4116 @shrouti1507 @ItsSudip @saikumarrs @sandeepdsvs @bardisg