Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): pull main into develop post release v3.0.0-beta.29 #1648

Merged
merged 7 commits into from
Mar 18, 2024

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Mar 18, 2024

PR Description

Please include a summary of the change along with the relevant motivation and context.

Linear task (optional)

Linear task link

Cross Browser Tests

Please confirm you have tested for the following browsers:

  • Chrome
  • Firefox
  • IE11

Sanity Suite

  • All sanity suite test cases pass locally

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Summary by CodeRabbit

  • Bug Fixes
    • Fixed a bug in the Ninetailed sample app path.
  • New Features
    • Released new beta versions for analytics-js, analytics-js-plugins, and analytics-js-loading-scripts.
  • Documentation
    • Updated release dates and version comparison links in changelogs.
    • Updated sonar.projectVersion to reflect the latest version.
  • Chores
    • Generated updates using @jscutlery/semver for several packages.

Copy link
Contributor

coderabbitai bot commented Mar 18, 2024

Walkthrough

The recent updates across various packages in the analytics-js ecosystem mark a progression towards stability and enhancement. With a focus on fixing bugs, updating changelogs, and improving functionality through the use of @jscutlery/semver, these changes signal a concerted effort to refine the user experience and developer interaction with the @rudderstack/analytics-js suite of tools, all dated March 18, 2024.

Changes

Files Change Summary
.../analytics-js-integrations/CHANGELOG.md Bug fix for ninetailed sample app path in 3.0.0-beta.26.
.../analytics-js-plugins/CHANGELOG.md, .../analytics-js-plugins/CHANGELOG_LATEST.md Updates related to release dates, version comparison links, and version update to 3.0.0-beta.21.
.../analytics-js/CHANGELOG.md, .../analytics-js/CHANGELOG_LATEST.md New beta release 3.0.0-beta.24 introduced.
.../loading-scripts/CHANGELOG.md, .../loading-scripts/CHANGELOG_LATEST.md Functionality updates in 3.0.0-beta.22 using @jscutlery/semver.
.../sanity-suite/CHANGELOG.md Updates in 3.0.0-beta.25 generated using @jscutlery/semver.
sonar-project.properties sonar.projectVersion updated to 3.0.0-beta.29.

Poem

🐰✨
In the world of code, where changes are bold,
A rabbit hopped in, with updates untold.
With a flick and a hop, and a skip in its step,
"To improve and to fix," was its pep.
📦🔄
From scripts that load, to analytics that track,
The rabbit ensures, nothing's out of whack.
"Onward we hop, to the future, we leap!"
In the code, we trust, in the changes, we keep.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 53.89%. Comparing base (bdf5e6e) to head (2d804a5).
Report is 8 commits behind head on develop.

Files Patch % Lines
...omponents/capabilitiesManager/detection/storage.ts 0.00% 1 Missing ⚠️
packages/analytics-v1.1/src/utils/JSFileLoader.js 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1648      +/-   ##
===========================================
+ Coverage    52.44%   53.89%   +1.45%     
===========================================
  Files          584      461     -123     
  Lines        16662    15588    -1074     
  Branches      3243     3097     -146     
===========================================
- Hits          8738     8401     -337     
+ Misses        6487     5881     -606     
+ Partials      1437     1306     -131     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@saikumarrs saikumarrs merged commit 14797b5 into develop Mar 18, 2024
12 checks passed
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 7792d3c and 2d804a5.
Files ignored due to path filters (11)
  • package-lock.json is excluded by: !**/*.json
  • package.json is excluded by: !**/*.json
  • packages/analytics-js-integrations/package.json is excluded by: !**/*.json
  • packages/analytics-js-integrations/project.json is excluded by: !**/*.json
  • packages/analytics-js-plugins/package.json is excluded by: !**/*.json
  • packages/analytics-js-plugins/project.json is excluded by: !**/*.json
  • packages/analytics-js/package.json is excluded by: !**/*.json
  • packages/analytics-js/project.json is excluded by: !**/*.json
  • packages/loading-scripts/package.json is excluded by: !**/*.json
  • packages/loading-scripts/project.json is excluded by: !**/*.json
  • packages/sanity-suite/package.json is excluded by: !**/*.json
Files selected for processing (10)
  • packages/analytics-js-integrations/CHANGELOG.md (1 hunks)
  • packages/analytics-js-integrations/CHANGELOG_LATEST.md (1 hunks)
  • packages/analytics-js-plugins/CHANGELOG.md (1 hunks)
  • packages/analytics-js-plugins/CHANGELOG_LATEST.md (1 hunks)
  • packages/analytics-js/CHANGELOG.md (1 hunks)
  • packages/analytics-js/CHANGELOG_LATEST.md (1 hunks)
  • packages/loading-scripts/CHANGELOG.md (1 hunks)
  • packages/loading-scripts/CHANGELOG_LATEST.md (1 hunks)
  • packages/sanity-suite/CHANGELOG.md (1 hunks)
  • sonar-project.properties (1 hunks)
Files skipped from review due to trivial changes (2)
  • packages/analytics-js-plugins/CHANGELOG_LATEST.md
  • sonar-project.properties
Additional comments: 10
packages/analytics-js/CHANGELOG_LATEST.md (1)
  • 1-1: The changelog update for version 3.0.0-beta.24 of @rudderstack/analytics-js is correctly formatted and includes the appropriate comparison link and release date.
packages/loading-scripts/CHANGELOG_LATEST.md (1)
  • 1-1: The changelog update for version 3.0.0-beta.22 of analytics-js-loading-scripts is correctly formatted and includes the appropriate comparison link and release date.
packages/analytics-js-integrations/CHANGELOG_LATEST.md (1)
  • 1-6: The changelog update for version 3.0.0-beta.26 of @rudderstack/analytics-js-integrations is correctly formatted and includes the appropriate comparison link, release date, and a detailed bug fix entry for the ninetailed sample app path.
packages/loading-scripts/CHANGELOG.md (1)
  • 2-9: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-5]

The changelog update for version 3.0.0-beta.22 of @rudderstack/analytics-js-loading-scripts is correctly formatted and includes the appropriate comparison link, release date, and mentions that the file was generated using @jscutlery/semver. This transparency in the changelog generation process is appreciated.

packages/sanity-suite/CHANGELOG.md (1)
  • 5-6: The entry for version 3.0.0-beta.25 is well-formatted and follows the established changelog pattern. If there were specific changes or updates in this version, consider adding a brief description to provide more context to the users.
packages/analytics-js-plugins/CHANGELOG.md (1)
  • 5-6: The changelog entry for version 3.0.0-beta.21 correctly documents the release date and provides a comparison link to the previous version. This is a good practice as it helps users quickly identify what changes have been made in the new version.
packages/analytics-js-integrations/CHANGELOG.md (1)
  • 5-10: The update to version 3.0.0-beta.26 with the bug fix for the ninetailed sample app path is clearly documented. It's good practice to include both the issue number and the commit hash for traceability. Well done.
packages/analytics-js/CHANGELOG.md (3)
  • 2-9: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-235]

The format and structure of the CHANGELOG.md file are well-organized and follow best practices for documenting changes in a project. It's clear and easy to navigate through different versions and their respective changes.

  • 2-9: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-235]

The content of the CHANGELOG.md file is clear and provides accurate information about the changes, including version updates, features, and bug fixes. The inclusion of links to issues and commits is beneficial for users seeking more details.

  • 2-9: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-235]

Upon review, the static analysis hints suggesting possible spelling mistakes and unpaired symbols have been evaluated. In the context of this CHANGELOG.md file, these hints are determined to be false positives, primarily due to the inclusion of technical terms, package names, and markdown syntax. No action is required to address these hints.

Copy link

sonarcloud bot commented Mar 18, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

size-limit report 📦

Name Size (Base) Size (Current) Size Limit Status
Common Code - No bundling 15.81 KB 15.81 KB (0%) 16.5 KB
Remote Module Federation Mapping - CDN 330 B 330 B (0%) 512 B
Remote Module Federated Plugins - CDN 5.71 KB 5.71 KB (0%) 6 KB
Core ESM - NPM 7.64 KB 7.64 KB (0%) 8 KB
Core CJS - NPM 22.43 KB 22.43 KB (0%) 23 KB
Core - NPM 22.6 KB 22.6 KB (0%) 23 KB
Core Legacy - CDN 42.88 KB 42.88 KB (0%) 44 KB
Core - CDN 22.7 KB 22.7 KB (0%) 23 KB
Core (legacy build) - CDN - v1.1 31.54 KB 31.54 KB (0%) 32 KB
Core - NPM - v1.1 31.52 KB 31.52 KB (0%) 32 KB
Service Worker Module 22.64 KB 22.64 KB (0%) 24 KB
All Integrations (legacy build) - CDN 98.57 KB 98.57 KB (0%) 105 KB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants