-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): pull main into develop post release v3.0.0-beta.29 #1648
Conversation
WalkthroughThe recent updates across various packages in the analytics-js ecosystem mark a progression towards stability and enhancement. With a focus on fixing bugs, updating changelogs, and improving functionality through the use of Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1648 +/- ##
===========================================
+ Coverage 52.44% 53.89% +1.45%
===========================================
Files 584 461 -123
Lines 16662 15588 -1074
Branches 3243 3097 -146
===========================================
- Hits 8738 8401 -337
+ Misses 6487 5881 -606
+ Partials 1437 1306 -131 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (11)
package-lock.json
is excluded by:!**/*.json
package.json
is excluded by:!**/*.json
packages/analytics-js-integrations/package.json
is excluded by:!**/*.json
packages/analytics-js-integrations/project.json
is excluded by:!**/*.json
packages/analytics-js-plugins/package.json
is excluded by:!**/*.json
packages/analytics-js-plugins/project.json
is excluded by:!**/*.json
packages/analytics-js/package.json
is excluded by:!**/*.json
packages/analytics-js/project.json
is excluded by:!**/*.json
packages/loading-scripts/package.json
is excluded by:!**/*.json
packages/loading-scripts/project.json
is excluded by:!**/*.json
packages/sanity-suite/package.json
is excluded by:!**/*.json
Files selected for processing (10)
- packages/analytics-js-integrations/CHANGELOG.md (1 hunks)
- packages/analytics-js-integrations/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js-plugins/CHANGELOG.md (1 hunks)
- packages/analytics-js-plugins/CHANGELOG_LATEST.md (1 hunks)
- packages/analytics-js/CHANGELOG.md (1 hunks)
- packages/analytics-js/CHANGELOG_LATEST.md (1 hunks)
- packages/loading-scripts/CHANGELOG.md (1 hunks)
- packages/loading-scripts/CHANGELOG_LATEST.md (1 hunks)
- packages/sanity-suite/CHANGELOG.md (1 hunks)
- sonar-project.properties (1 hunks)
Files skipped from review due to trivial changes (2)
- packages/analytics-js-plugins/CHANGELOG_LATEST.md
- sonar-project.properties
Additional comments: 10
packages/analytics-js/CHANGELOG_LATEST.md (1)
- 1-1: The changelog update for version 3.0.0-beta.24 of
@rudderstack/analytics-js
is correctly formatted and includes the appropriate comparison link and release date.packages/loading-scripts/CHANGELOG_LATEST.md (1)
- 1-1: The changelog update for version 3.0.0-beta.22 of
analytics-js-loading-scripts
is correctly formatted and includes the appropriate comparison link and release date.packages/analytics-js-integrations/CHANGELOG_LATEST.md (1)
- 1-6: The changelog update for version 3.0.0-beta.26 of
@rudderstack/analytics-js-integrations
is correctly formatted and includes the appropriate comparison link, release date, and a detailed bug fix entry for the ninetailed sample app path.packages/loading-scripts/CHANGELOG.md (1)
- 2-9: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-5]
The changelog update for version 3.0.0-beta.22 of
@rudderstack/analytics-js-loading-scripts
is correctly formatted and includes the appropriate comparison link, release date, and mentions that the file was generated using@jscutlery/semver
. This transparency in the changelog generation process is appreciated.packages/sanity-suite/CHANGELOG.md (1)
- 5-6: The entry for version 3.0.0-beta.25 is well-formatted and follows the established changelog pattern. If there were specific changes or updates in this version, consider adding a brief description to provide more context to the users.
packages/analytics-js-plugins/CHANGELOG.md (1)
- 5-6: The changelog entry for version 3.0.0-beta.21 correctly documents the release date and provides a comparison link to the previous version. This is a good practice as it helps users quickly identify what changes have been made in the new version.
packages/analytics-js-integrations/CHANGELOG.md (1)
- 5-10: The update to version 3.0.0-beta.26 with the bug fix for the ninetailed sample app path is clearly documented. It's good practice to include both the issue number and the commit hash for traceability. Well done.
packages/analytics-js/CHANGELOG.md (3)
- 2-9: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-235]
The format and structure of the CHANGELOG.md file are well-organized and follow best practices for documenting changes in a project. It's clear and easy to navigate through different versions and their respective changes.
- 2-9: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-235]
The content of the CHANGELOG.md file is clear and provides accurate information about the changes, including version updates, features, and bug fixes. The inclusion of links to issues and commits is beneficial for users seeking more details.
- 2-9: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-235]
Upon review, the static analysis hints suggesting possible spelling mistakes and unpaired symbols have been evaluated. In the context of this CHANGELOG.md file, these hints are determined to be false positives, primarily due to the inclusion of technical terms, package names, and markdown syntax. No action is required to address these hints.
Quality Gate passedIssues Measures |
size-limit report 📦
|
PR Description
Please include a summary of the change along with the relevant motivation and context.
Linear task (optional)
Linear task link
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit
analytics-js
,analytics-js-plugins
, andanalytics-js-loading-scripts
.sonar.projectVersion
to reflect the latest version.@jscutlery/semver
for several packages.