-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added date type in apiobject and apioptions #1666
feat: added date type in apiobject and apioptions #1666
Conversation
WalkthroughThe recent update introduces the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (2)
- packages/analytics-js-common/src/types/ApiObject.ts (1 hunks)
- packages/analytics-js-common/src/types/EventApi.ts (1 hunks)
Additional comments: 2
packages/analytics-js-common/src/types/ApiObject.ts (1)
- 12-12: The addition of the
Date
type to theApiObject
definition is a welcome enhancement, aligning with the PR's objectives to support a wider range of data types.Please ensure that the handling of
Date
objects, especially in terms of serialization and deserialization, is thoroughly tested across different parts of the library to maintain data integrity and compatibility.packages/analytics-js-common/src/types/EventApi.ts (1)
- 25-25: The inclusion of the
Date
type in theApiOptions
type definition enhances the library's data handling capabilities, consistent with the PR's objectives.As with the
ApiObject
changes, please ensure that the handling ofDate
objects withinApiOptions
, particularly regarding serialization and deserialization, is thoroughly tested to ensure data integrity and compatibility.
Quality Gate passedIssues Measures |
size-limit report 📦
|
PR Description
Please include a summary of the change along with the relevant motivation and context.
Linear task (optional)
https://linear.app/rudderstack/issue/SDK-1416/add-more-type-in-apiobject-interface
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit
Date
, enhancing event tracking capabilities.