-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(release): pull main into develop post release v3.4.0 #1676
Conversation
WalkthroughThe updates encompass a crucial bug fix in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1676 +/- ##
========================================
Coverage 53.90% 53.90%
========================================
Files 461 461
Lines 15611 15611
Branches 3102 3091 -11
========================================
Hits 8415 8415
- Misses 5890 5907 +17
+ Partials 1306 1289 -17 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (5)
package-lock.json
is excluded by:!**/*.json
package.json
is excluded by:!**/*.json
packages/analytics-v1.1/package.json
is excluded by:!**/*.json
packages/analytics-v1.1/project.json
is excluded by:!**/*.json
packages/sanity-suite/package.json
is excluded by:!**/*.json
Files selected for processing (4)
- packages/analytics-v1.1/CHANGELOG.md (1 hunks)
- packages/analytics-v1.1/CHANGELOG_LATEST.md (1 hunks)
- packages/sanity-suite/CHANGELOG.md (1 hunks)
- sonar-project.properties (1 hunks)
Files skipped from review due to trivial changes (2)
- packages/sanity-suite/CHANGELOG.md
- sonar-project.properties
Additional comments: 2
packages/analytics-v1.1/CHANGELOG_LATEST.md (1)
- 1-6: The changelog entry for version
2.48.6
is clear and follows the conventional format, including a detailed description of the bug fix and relevant links. This change, moving the analytics common package to dev dependencies, is a good practice for dependency management, potentially reducing unnecessary production dependencies.packages/analytics-v1.1/CHANGELOG.md (1)
- 5-11: The CHANGELOG update for version 2.48.6 is well-documented, following conventional formatting practices. It clearly outlines the bug fix and includes relevant links for traceability. This is a good practice for maintaining project history and facilitating understanding of changes.
Quality Gate passedIssues Measures |
size-limit report 📦
|
PR Description
Please include a summary of the change along with the relevant motivation and context.
Linear task (optional)
Linear task link
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security
Summary by CodeRabbit