Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: event API overloads #1782

Merged
merged 25 commits into from
Jul 17, 2024
Merged
Show file tree
Hide file tree
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
a17adbd
fix: event api overloads
saikumarrs Jul 6, 2024
0bc2b18
chore: fix track api overload tests
saikumarrs Jul 7, 2024
dfcae9e
fix: all issues with event api overloads
saikumarrs Jul 7, 2024
602407f
fix: page api overloads and sanity suite
saikumarrs Jul 10, 2024
7167ba3
Merge remote-tracking branch 'origin/develop' into fix.event-overload…
saikumarrs Jul 11, 2024
dae39b2
fix: api overloads for destination analytics instance
saikumarrs Jul 11, 2024
3c76329
fix: api overloads types
saikumarrs Jul 11, 2024
9ba3c44
chore: remove circular dependencies check temporarily to avoid vulner…
saikumarrs Jul 11, 2024
2e864dd
fix: avoid delete operator
saikumarrs Jul 11, 2024
41e6b17
chore: address lint issues
saikumarrs Jul 11, 2024
f8615b6
chore: Update packages/sanity-suite/src/testBookSuites/alias.js
saikumarrs Jul 15, 2024
48a9fc1
chore: fix targets and size limit configuration
saikumarrs Jul 16, 2024
08c1ad0
chore: build packages for publint
saikumarrs Jul 16, 2024
4be7f6f
chore: fix pacakge.json for publint
saikumarrs Jul 16, 2024
9d72b42
chore: do not remove type declaration files
saikumarrs Jul 16, 2024
2f52d63
chore: use apiOptions naming
saikumarrs Jul 16, 2024
60364f9
chore: fix type
saikumarrs Jul 16, 2024
ce64375
fix: remove unwanted code and improve coverage
saikumarrs Jul 16, 2024
5f397fa
chore: fix package script
saikumarrs Jul 16, 2024
595f2b6
chore: update precommit hook to run for only affected projects
saikumarrs Jul 16, 2024
7fc1db3
chore: run scripts only for affected packages
saikumarrs Jul 16, 2024
f8585de
chore: fix setup:ci script
saikumarrs Jul 16, 2024
d566427
chore: fix base ref
saikumarrs Jul 16, 2024
bc996f5
chore: fetch all commits
saikumarrs Jul 16, 2024
811b607
chore: restore size build behavior
saikumarrs Jul 16, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/draft-new-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ jobs:
npm run bump-version:monorepo
npx replace $CURRENT_VERSION_VALUE $NEW_VERSION_VALUE sonar-project.properties
npm run clean
npm run setup
git add .
git commit -m "chore(monorepo): sync versions and generate release logs" -n

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,12 +26,13 @@ jobs:
uses: rudderlabs/[email protected]
env:
HUSKY: 0
BASE_REF: ${{ github.event.pull_request.base.ref }}
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
install_script: setup:ci
build_script: check:size:build
build_script: check:size:build:ci
clean_script: clean
script: npm run check:size:json:ci --silent -- --output-style=static --silent=true --exclude=@rudderstack/analytics-js-sanity-suite,@rudderstack/analytics-js-loading-scripts
script: npm run check:size:json:ci --silent -- --output-style=static --silent=true --exclude=@rudderstack/analytics-js-sanity-suite
is_monorepo: true

security-code-quality-checks:
Expand All @@ -56,12 +57,20 @@ jobs:

- name: Execute code quality checks
run: |
npm run check:circular
npm run check:duplicates

- name: Build the project
env:
BASE_REF: ${{ github.event.pull_request.base.ref }}
run: |
npm run build:ci
npm run build:modern:ci

- name: Execute package linting checks
env:
BASE_REF: ${{ github.event.pull_request.base.ref }}
run: |
npm run check:pub
npm run check:pub:ci

- name: Execute security checks
run: |
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/unit-tests-and-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ jobs:
npm run setup:ci

- name: Execute unit tests
env:
BASE_REF: ${{ github.event.pull_request.base.ref || 'HEAD' }}
run: |
npm run test:ci

Expand All @@ -46,6 +48,8 @@ jobs:
files: ./packages/analytics-js/reports/coverage/clover.xml,./packages/analytics-js-common/reports/coverage/clover.xml,./packages/analytics-js-integrations/reports/coverage/clover.xml,./packages/analytics-js-plugins/reports/coverage/clover.xml,./packages/analytics-js-service-worker/reports/coverage/clover.xml,./packages/analytics-v1.1/reports/coverage/clover.xml,./packages/analytics-js-cookies/reports/coverage/clover.xml

- name: Execute linting check
env:
BASE_REF: ${{ github.event.pull_request.base.ref || 'HEAD' }}
run: |
npm run check:lint:ci

Expand Down
39 changes: 29 additions & 10 deletions nx.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,27 +37,23 @@
"inputs": ["default", "^production"],
"cache": true
},
"build-browser": {
"build:modern": {
"inputs": ["default", "^production"],
"cache": true
},
"build-browser-modern": {
"build:browser": {
"inputs": ["default", "^production"],
"cache": true
},
"build-npm": {
"build:browser:modern": {
"inputs": ["default", "^production"],
"cache": true
},
"build-npm-modern": {
"build:package": {
"inputs": ["default", "^production"],
"cache": true
},
"build-package": {
"inputs": ["default", "^production"],
"cache": true
},
"build-check-size": {
"build:package:modern": {
"inputs": ["default", "^production"],
"cache": true
},
Expand All @@ -66,12 +62,34 @@
"cache": true
},
"check:size:json": {
"inputs": ["default", "^production", "{projectRoot}/.size-limit.js"],
"inputs": [
"default",
"^production",
"{projectRoot}/.size-limit.js",
"{projectRoot}/.size-limit.mjs"
],
"cache": true
},
"check:pub": {
"inputs": ["{projectRoot}/package.json"],
"cache": true
},
"test:pre-commit:affected": {
"inputs": ["default", "^test"],
"cache": true
},
"check:size:build:pre-commit:affected": {
"inputs": ["default", "^production"],
"cache": true
},
"check:size:json:pre-commit:affected": {
"inputs": [
"default",
"^production",
"{projectRoot}/.size-limit.js",
"{projectRoot}/.size-limit.mjs"
],
"cache": true
}
},
"generators": {
Expand All @@ -95,6 +113,7 @@
"!{projectRoot}/**/*.txt",
"!{projectRoot}/serve.json",
"!{projectRoot}/.size-limit.js",
"!{projectRoot}/.size-limit.mjs",
"!{projectRoot}/.jscpd.json",
"{workspaceRoot}/tsconfig.build.json",
"{workspaceRoot}/tsconfig.json",
Expand Down
Loading
Loading