chore(analytics-js-sanity-suite): fix text wrapping for buttons #1822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughWalkthroughThe recent changes primarily enhance the HTML semantics and visual presentation of the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TestBook
participant Button
User->>TestBook: Interacts with component
TestBook->>Button: Applies styling changes
Button-->>User: Displays updated button
Note over User, TestBook: Improved accessibility and semantics
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- packages/sanity-suite/src/testBook/TestBook.js (7 hunks)
Files skipped from review due to trivial changes (1)
- packages/sanity-suite/src/testBook/TestBook.js
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1822 +/- ##
========================================
Coverage 56.79% 56.79%
========================================
Files 476 476
Lines 16191 16191
Branches 3226 3235 +9
========================================
Hits 9196 9196
+ Misses 5779 5733 -46
- Partials 1216 1262 +46 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
MoumitaM
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixed the text wrapping of the buttons in the sanity suite HTML page that prevents them from being clicked via web driver IO on mobile devices (with smaller viewports) thereby failing the E2E test suite on Samsung devices.
Here is the E2E test suite run report of one of the failing features with the changes fixed in the sanity suite:
https://automate.browserstack.com/dashboard/v2/builds/c663cd294a85447f47dda0893893e7f7ad171adc?overallStatus=completed&projectIds=2116906
Linear task (optional)
https://linear.app/rudderstack/issue/SDK-2181/fix-e2e-test-suite-failures-in-mobile-browsers-js-sdk
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security