fix: batch entry retry #1918
Merged
fix: batch entry retry #1918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## hotfix/revert-sanitization #1918 +/- ##
=============================================================
Coverage ? 57.52%
=============================================================
Files ? 485
Lines ? 16505
Branches ? 3310
=============================================================
Hits ? 9494
Misses ? 5742
Partials ? 1269 ☔ View full report in Codecov by Sentry. |
size-limit report 📦
|
|
MoumitaM
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR fixes, #1917.
When a batch request fails and is retryable, as part of the requeue action, the entry which is an array of individual events is added to the "batch" queue in the batching mode.
The batch queue should only contain single event items and when it is time to dispatch a batch, we generate a queue item out of all those events.
Since an array of events is added to the batch queue, it fails at the next processing step.
I've updated the RetryQueue module to mark the entries explicitly as batch and single. This way, only single event items are added to the batch queue preventing this issue and successful retries of those entries.
Moreover, while reclaiming stale queues that may not contain this item-type parameter, we temporarily determine it based on the contents of the item.
This will not be needed in the long run.
Linear task (optional)
https://linear.app/rudderstack/issue/SDK-2606/fix-retry-of-batched-requests
Cross Browser Tests
Please confirm you have tested for the following browsers:
Sanity Suite
Security