Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: removed traits from event level #17

Merged
merged 1 commit into from
Sep 13, 2023

Conversation

pallabmaiti
Copy link

@pallabmaiti pallabmaiti commented Sep 12, 2023

Description

Removed traits from the event level.

@pallabmaiti pallabmaiti changed the title feat!: removed traits from event level feat: removed traits from event level Sep 12, 2023
@pallabmaiti pallabmaiti force-pushed the feat/remove-top-level-traits branch from 4fc07c5 to f33d8e9 Compare September 12, 2023 10:29
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01% ⚠️

Comparison is base (bf04d8f) 97.23% compared to head (f33d8e9) 97.23%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   97.23%   97.23%   -0.01%     
==========================================
  Files          13       13              
  Lines         507      506       -1     
==========================================
- Hits          493      492       -1     
  Misses         14       14              
Files Changed Coverage Δ
lib/rudder/analytics/field_parser.rb 100.00% <ø> (ø)
lib/rudder/analytics/transport.rb 91.66% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@bardisg bardisg self-requested a review September 13, 2023 07:51
@pallabmaiti pallabmaiti merged commit a968836 into master Sep 13, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants