-
Notifications
You must be signed in to change notification settings - Fork 118
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: fix lint and formatting issues (#2024)
* refactor: fix lint issues * refactor: fix formatting issues * fix: fixing eslint warnings * feat: integrate sonar cloud scan * fix: add the missing file * fix: add eslint sonarjs package * fix: update sonar cloud scan exclusion list * fix: add cache option to eslint command * refactor: fix lint issues * refactor: fix formatting issues * fix: fixing eslint warnings * feat: integrate sonar cloud scan * fix: add the missing file * fix: add eslint sonarjs package * fix: update sonar cloud scan exclusion list * fix: add cache option to eslint command * fix: add missing files in the recent merge * chore: remove deepsource configuration * chore: format code * chore: fix additional linting issues * fix: issues to make tests pass * chore: replace map with forEach * chore: add .eslintcache to .gitignore * refactor: reduce cognitive complexity of a utility method * refactor: reduce cognitive complexity * chore: add lint fix job to the workflows * refactor: fixing issues for freshsales freshmarketers and facebook dests * refactor: fixing issues for active campaign adobe adj and newrelic * refactor: webengage, tiktok, snapchat, adobe issue address * refactor: remove warnings related to switch * refactor: fix cognitive errors, remove warnings related to switch-2 * refactor: fix GAOC issues * feat: upload reports irrespective of lint check failures * refactor: customerio, active campaign refactor issue address * refactor: iterable refactor issue address * refactor: profitwell refactor issue address * refactor: monetate refactor issue address * refactor: ga refactor issue address * refactor: fbPixel refactor issue address * refactor: braze refactor issue address * refactor: fixing refactor issue of gaoc * refactor: unit tests added for braze, customerio, fbpixel, ga, gaoc, iterable, monetate, profitwell * refactor: unit tests edited profitwell * refactor: eslint issue fix * chore: ci/cd sonar cloud version change * refactor: fixing shopify sources according to develop * refactor: fixing resolve conflicts * refactor: undefined issue solve * refactor: undefined issue solve for facebook pixel * refactor: undefined issue solve for facebook pixel * refactor: removing unused constant for criteo audience * chore: format and lint code * chore: format and lint ts files * fix: add missing file * refactor: temporary switch off some lint rules, to be addressed in the following PR * Revert "refactor: temporary switch off some lint rules, to be addressed in the following PR" This reverts commit 1c0a879. * refactor: temporary switch off some lint rules, to be addressed in the following PR * refactor: test case failure edis * refactor: env file missing field addition * refactor: removing unnecessary files of braze * refactor: remove extra log --------- Co-authored-by: shrouti1507 <[email protected]> Co-authored-by: shrouti1507 <[email protected]> Co-authored-by: Yashasvi Bajpai <[email protected]>
- Loading branch information
1 parent
71c1e7a
commit 30160a7
Showing
345 changed files
with
22,305 additions
and
13,947 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,5 @@ | ||
* | ||
!src | ||
!features.json | ||
!Makefile | ||
!jest*.js | ||
!benchmark | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,22 @@ | ||
node_modules/ | ||
.husky/ | ||
reports/ | ||
test/ | ||
benchmark/ | ||
dist/ | ||
**/warehouse/ | ||
**/lambda/ | ||
**/openfaas/ | ||
*.md | ||
*.test.js | ||
test/**/*.js | ||
*.test.ts | ||
src/util/lodash-es-core.js | ||
**/ivm*.js | ||
**/custom*.js | ||
**/warehouse/ | ||
**/lambda/ | ||
**/openfaas/ | ||
src/util/url-search-params.min.js | ||
src/logger.js | ||
src/util/eventValidations.js | ||
**/trackingPlan* | ||
src/v0/destinations/personalize/scripts/ | ||
test/integrations/destinations/testTypes.d.ts | ||
*.config*.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -147,4 +147,3 @@ jobs: | |
build-args: | | ||
version=${{ steps.gen_tag_name.outputs.tag_name }} | ||
GIT_COMMIT_SHA=${{ github.sha }} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -119,4 +119,3 @@ jobs: | |
} | ||
] | ||
} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -25,9 +25,28 @@ jobs: | |
run: npm ci | ||
|
||
- name: Run Tests | ||
run: npm run test:ci | ||
run: | | ||
npm run test:ci | ||
- name: Run Lint Checks | ||
run: | | ||
npm run check:lint | ||
npm run lint:fix | ||
- name: Upload Coverage Reports to Codecov | ||
uses: codecov/[email protected] | ||
with: | ||
directory: ./reports/coverage | ||
|
||
- name: Fix filesystem paths in generated reports | ||
if: always() | ||
run: | | ||
sed -i 's+home/runner/work/rudder-transformer/rudder-transformer+/github/workspace+g' reports/coverage/lcov.info | ||
sed -i 's+/home/runner/work/rudder-transformer/rudder-transformer+/github/workspace+g' reports/eslint.json | ||
- name: SonarCloud Scan | ||
if: always() | ||
uses: SonarSource/[email protected] | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,4 +3,6 @@ | |
node_modules | ||
npm-debug.log | ||
reports/* | ||
dist | ||
.eslintcache | ||
dist | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
module.exports = { | ||
extends: ['@commitlint/config-conventional'], | ||
rules: { | ||
'type-enum': () => [2, 'always', ['fix', 'feat', 'chore', 'refactor', 'docs', 'test']] | ||
} | ||
'type-enum': () => [2, 'always', ['fix', 'feat', 'chore', 'refactor', 'docs', 'test']], | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
module.exports = { | ||
gitRawCommitsOpts: { | ||
merges: null | ||
} | ||
} | ||
gitRawCommitsOpts: { | ||
merges: null, | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.