Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skipping users events for snowpipe streaming #3836

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

achettyiitr
Copy link
Member

What are the changes introduced in this PR?

  • Skipping users events for Snowpipe streaming destination.

What is the related Linear task?

  • Resolves PIPE-1690

@achettyiitr achettyiitr requested review from a team as code owners October 30, 2024 05:28
@achettyiitr achettyiitr changed the title fix: snowpipe streaming users table skipping fix: skipping users events for snowpipe streaming Oct 30, 2024
@achettyiitr achettyiitr force-pushed the fix.snowpipe-streaming-users branch from c9c93e3 to b43bbaa Compare October 30, 2024 05:31
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Oct 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.48%. Comparing base (70fa123) to head (c1b39f2).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3836   +/-   ##
========================================
  Coverage    90.47%   90.48%           
========================================
  Files          615      615           
  Lines        32329    32339   +10     
  Branches      7681     7689    +8     
========================================
+ Hits         29251    29261   +10     
- Misses        2822     2854   +32     
+ Partials       256      224   -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ktgowtham ktgowtham requested review from cisse21 and mihir20 November 12, 2024 11:07
@achettyiitr achettyiitr force-pushed the fix.snowpipe-streaming-users branch 2 times, most recently from 5ab0f1c to 2e13447 Compare November 25, 2024 07:04
@achettyiitr achettyiitr requested review from sivashanmukh and a team as code owners November 25, 2024 07:04
@achettyiitr achettyiitr force-pushed the fix.snowpipe-streaming-users branch 3 times, most recently from 017029f to 19988fc Compare November 25, 2024 19:09
@ktgowtham ktgowtham requested review from ktgowtham and removed request for sivashanmukh, cisse21 and mihir20 November 28, 2024 11:14
ktgowtham
ktgowtham previously approved these changes Dec 2, 2024
Copy link
Contributor

@ktgowtham ktgowtham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. added minor comments

src/v0/destinations/snowpipe_streaming/transform.js Outdated Show resolved Hide resolved
src/warehouse/identity.js Outdated Show resolved Hide resolved
@ktgowtham ktgowtham requested a review from cisse21 December 3, 2024 11:04
Copy link

sonarcloud bot commented Dec 6, 2024

@achettyiitr achettyiitr requested a review from ItsSudip December 8, 2024 13:35
Copy link

@satishrudderstack satishrudderstack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock merge

@achettyiitr achettyiitr merged commit 12621c8 into develop Dec 9, 2024
27 checks passed
@achettyiitr achettyiitr deleted the fix.snowpipe-streaming-users branch December 9, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants