-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update on twitter_ads #3856
Conversation
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3856/test-report.html |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3856 +/- ##
===========================================
- Coverage 89.02% 89.01% -0.01%
===========================================
Files 610 610
Lines 32918 32950 +32
Branches 7779 7786 +7
===========================================
+ Hits 29305 29332 +27
- Misses 3330 3335 +5
Partials 283 283 ☔ View full report in Codecov by Sentry. |
Quality Gate passedIssues Measures |
What are the changes introduced in this PR?
Updated Twitter Ads integration to include two additional identifiers: ip_address and user_agent.
What is the related Linear task?
Resolves INT-2704
Doc: https://developer.x.com/en/docs/x-ads-api/measurement/web-conversions/api-reference/conversions
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.