Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding throttled status code for server unavailable error in salesforce #3862

Merged
merged 5 commits into from
Nov 11, 2024

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Nov 11, 2024

What are the changes introduced in this PR?

For salesforce when the salesforce server is busy or unavailable we were throwing retriable which was being failed eventually by retrying 3 times.
Now, we are throwing 429 status code appropriately.

What is the related Linear task?

Resolves INT-2847

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 self-assigned this Nov 11, 2024
@shrouti1507 shrouti1507 requested review from a team and sivashanmukh as code owners November 11, 2024 06:32
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.02%. Comparing base (bbd31a1) to head (69b5669).
Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3862      +/-   ##
===========================================
- Coverage    89.02%   89.02%   -0.01%     
===========================================
  Files          610      610              
  Lines        32918    32957      +39     
  Branches      7779     7789      +10     
===========================================
+ Hits         29305    29339      +34     
+ Misses        3330     3305      -25     
- Partials       283      313      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shrouti1507 shrouti1507 requested a review from utsabc November 11, 2024 06:45
utsabc
utsabc previously approved these changes Nov 11, 2024
Copy link

sonarcloud bot commented Nov 11, 2024

@shrouti1507 shrouti1507 merged commit fa93f09 into develop Nov 11, 2024
27 of 34 checks passed
@shrouti1507 shrouti1507 deleted the fix.salesforce_status_code branch November 11, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants