-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add execution stats header to the ut response #3882
base: develop
Are you sure you want to change the base?
Conversation
Test report for this run is available at: https://test-integrations-dev.s3.amazonaws.com/integrations-test-reports/rudder-transformer/3882/test-report.html |
Quality Gate passedIssues Measures |
@@ -28,6 +28,8 @@ async function shutdownWorkers() { | |||
} | |||
|
|||
function start(port, app, metricsApp) { | |||
console.log(numWorkers); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
console.log(numWorkers); |
This PR is considered to be stale. It has been open for 20 days with no further activity thus it is going to be closed in 7 days. To avoid such a case please consider removing the stale label manually or add a comment to the PR. |
What are the changes introduced in this PR?
We are adding two new headers only in the response to the
/customTransform
call in the user-transformer service.The two headers and there format are as follows:
X-Response-Time:105.23ms
X-Instance-ID:<instance-id>/<worker-id>
In case the system is unable to determine the instance-id and worker-id from the env it will use the value
default
for the instance-id andmaster
for the worker-id. So overall the valud of theX-Instance-ID
will bedefault/master
What is the related Linear task?
Resolves DAT-1713
Please explain the objectives of your changes below
Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here
Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?
N/A
Any new dependencies introduced with this change?
N/A
Any new generic utility introduced or modified. Please explain the changes.
N/A
Any technical or performance related pointers to consider with the change?
N/A
@coderabbitai review
Developer checklist
My code follows the style guidelines of this project
No breaking changes are being introduced.
All related docs linked with the PR?
All changes manually tested?
Any documentation changes needed with this change?
Is the PR limited to 10 file changes?
Is the PR limited to one linear task?
Are relevant unit and component test-cases added in new readability format?
Reviewer checklist
Is the type of change in the PR title appropriate as per the changes?
Verified that there are no credentials or confidential data exposed with the changes.