Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dedicated deployment for mktool customer #3901

Merged
merged 6 commits into from
Dec 9, 2024

Conversation

aashishmalik
Copy link
Contributor

@aashishmalik aashishmalik commented Nov 21, 2024

What are the changes introduced in this PR?

  1. Merges external_ids, emails, and phones for entries with the same subscription_group_id and subscription_state
  2. batch size set to 25

What is the related Linear task?

Resolves INT-XXX

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@aashishmalik aashishmalik requested a review from a team as a code owner November 21, 2024 12:01
@aashishmalik aashishmalik requested review from krishna2020 and chandumlg and removed request for a team November 21, 2024 12:01
@aashishmalik aashishmalik marked this pull request as draft November 21, 2024 12:01
@devops-github-rudderstack
Copy link
Contributor

Base automatically changed from hotfix-release/v1.85.1 to main November 21, 2024 12:06
Copy link

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.49%. Comparing base (b3f7140) to head (b7c27a0).
Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3901      +/-   ##
===========================================
+ Coverage    90.47%   90.49%   +0.01%     
===========================================
  Files          615      615              
  Lines        32329    32394      +65     
  Branches      7682     7706      +24     
===========================================
+ Hits         29250    29315      +65     
  Misses        2823     2823              
  Partials       256      256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aashishmalik aashishmalik requested a review from utsabc November 21, 2024 12:20
@aashishmalik aashishmalik changed the base branch from main to develop November 21, 2024 12:22
@aashishmalik aashishmalik changed the base branch from develop to main November 21, 2024 12:22
utsabc
utsabc previously approved these changes Nov 21, 2024
@aashishmalik aashishmalik requested a review from utsabc December 6, 2024 11:16
@aashishmalik aashishmalik changed the base branch from main to develop December 8, 2024 16:16
@aashishmalik aashishmalik marked this pull request as ready for review December 9, 2024 05:42
@aashishmalik aashishmalik requested review from a team and sivashanmukh as code owners December 9, 2024 05:42
@aashishmalik aashishmalik requested a review from utsabc December 9, 2024 06:37
Copy link

sonarcloud bot commented Dec 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
17.9% Duplication on New Code (required ≤ 15%)

See analysis details on SonarQube Cloud

@utsabc utsabc merged commit ebcf84e into develop Dec 9, 2024
24 of 25 checks passed
@utsabc utsabc deleted the fix.dedicated-braze-subscription branch December 9, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants