Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add date time support to hs #3906

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

fix: add date time support to hs #3906

wants to merge 7 commits into from

Conversation

utsabc
Copy link
Member

@utsabc utsabc commented Nov 25, 2024

What are the changes introduced in this PR?

This PR adds support for dateTime type of fields for HS correctly

What is the related Linear task?

Resolves INT-2867

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@utsabc utsabc requested a review from a team as a code owner November 25, 2024 09:35
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 96.73913% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.48%. Comparing base (275e971) to head (d03e33a).
Report is 29 commits behind head on develop.

Files with missing lines Patch % Lines
src/v0/destinations/hs/util.js 50.00% 2 Missing ⚠️
.../shopify/webhookTransformations/serverSideUtlis.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3906   +/-   ##
========================================
  Coverage    90.47%   90.48%           
========================================
  Files          615      615           
  Lines        32320    32363   +43     
  Branches      7677     7689   +12     
========================================
+ Hits         29242    29283   +41     
- Misses        2822     2856   +34     
+ Partials       256      224   -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ItsSudip ItsSudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some test cases for your changes?

Copy link
Contributor

@yashasvibajpai yashasvibajpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with tests, should be good

@utsabc utsabc added the DO NOT MERGE Don't merge this PR without having discussion label Nov 25, 2024
@utsabc utsabc requested review from sivashanmukh and a team as code owners December 12, 2024 07:43
Copy link

sonarcloud bot commented Dec 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this PR without having discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants