Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove references to legacy consent management fields #3931

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

saikumarrs
Copy link
Member

What are the changes introduced in this PR?

I've removed all the references to legacy consent management fields like OneTrust and Ketch. All the changes are in the test suite files.

What is the related Linear task?

https://linear.app/rudderstack/issue/SDK-664/replace-references-to-legacy-consent-configuration-fields-in-rudder

Please explain the objectives of your changes below

N/A

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@saikumarrs saikumarrs self-assigned this Dec 11, 2024
@saikumarrs saikumarrs requested review from a team and sivashanmukh as code owners December 11, 2024 04:50
Copy link
Contributor

@koladilip koladilip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens to older sdks?

@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.48%. Comparing base (b3f7140) to head (24a1aed).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3931      +/-   ##
===========================================
+ Coverage    90.47%   90.48%   +0.01%     
===========================================
  Files          615      615              
  Lines        32329    32360      +31     
  Branches      7682     7687       +5     
===========================================
+ Hits         29250    29282      +32     
- Misses        2823     2854      +31     
+ Partials       256      224      -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 11, 2024

@saikumarrs saikumarrs merged commit 325dabe into develop Dec 11, 2024
27 checks passed
@saikumarrs saikumarrs deleted the chore.remove-legacy-cm-utilities-sdk-664 branch December 11, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants