Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: customer workflow executor loading from yaml #88

Merged
merged 12 commits into from
Aug 31, 2023

Conversation

koladilip
Copy link
Collaborator

Description of the change

Now executor loading will leaverage bindings instead of loading separately.

Checklists

Development

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@github-actions
Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 100% 1481/1481
🟢 Branches 100% 300/300
🟢 Functions 100% 112/112
🟢 Lines 100% 1481/1481

Test suite run success

157 tests passing in 4 suites.

Report generated by 🧪jest coverage report action from 8699579

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cda8ad7) 100.00% compared to head (8699579) 100.00%.
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##              main       #88    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           45        46     +1     
  Lines         1372      1481   +109     
  Branches       249       266    +17     
==========================================
+ Hits          1372      1481   +109     
Files Changed Coverage Δ
src/steps/base/executors/base.ts 100.00% <ø> (ø)
src/steps/base/executors/workflow_step.ts 100.00% <ø> (ø)
src/steps/composed/executors/composable.ts 100.00% <ø> (ø)
src/bindings/common.ts 100.00% <100.00%> (ø)
src/steps/composed/executors/loop.ts 100.00% <100.00%> (ø)
src/steps/composed/factory.ts 100.00% <100.00%> (ø)
src/steps/errors.ts 100.00% <100.00%> (ø)
src/steps/types.ts 100.00% <100.00%> (ø)
src/steps/utils.ts 100.00% <100.00%> (ø)
src/workflow/default_executor.ts 100.00% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koladilip koladilip merged commit a1cfb6c into main Aug 31, 2023
6 checks passed
@koladilip koladilip deleted the refactor.custom-workflow-executor branch August 31, 2023 14:27
@github-actions github-actions bot mentioned this pull request Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants