Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default id stitchers not showing up in audit model #509

Merged
merged 4 commits into from
Nov 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ jobs:
run: black --check .

- name: Install dependencies
run: pip install -r tests/integration/requirements.txt
working-directory: src/predictions
run: pip3 install .

- name: Compile core train
run: python -m src.predictions.profiles_mlcorelib.ml_core.preprocess_and_train --mode ci
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,15 @@ def _set_id_stitcher_model(self, this: WhtMaterial):
if self.id_stitcher_model is not None:
return
id_stitcher_models = {}
models = this.base_wht_project.models(model_types=["id_stitcher"])
if len(models) == 0:
raise ValueError("No id_stitcher model found in the project")
# FIXME: Remove "identity" from the list once the ListModels bug is fixed in wht code
models = this.base_wht_project.models(model_types=["identity", "id_stitcher"])
for model in models:
# FIXME: Remove "id_collator" check once "identity" model type filter is removed
if model.model_type() == "id_collator":
dpatchigolla marked this conversation as resolved.
Show resolved Hide resolved
continue
id_stitcher_models[model.name()] = model
if len(id_stitcher_models) == 0:
raise ValueError("No id_stitcher model found in the project")
if len(id_stitcher_models) > 1:
max_retries = 5
retry_count = 0
Expand Down
1 change: 1 addition & 0 deletions src/predictions/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@
"networkx",
"pyvis",
"ruamel.yaml>=0.18.6",
"pytest",
]

setup(
Expand Down
31 changes: 0 additions & 31 deletions tests/integration/requirements.txt

This file was deleted.

Loading