Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

making node colors static across clusters #530

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

making node colors static across clusters #530

wants to merge 2 commits into from

Conversation

joker2411
Copy link
Collaborator

Description of the change

Ticket Link.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

dpatchigolla
dpatchigolla reviewed Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@dpatchigolla dpatchigolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments. can you also handle the scenario where we are deduplicating only ids, and not id, id_types

src/predictions/profiles_mlcorelib/py_native/id_stitcher/cluster_report.py Outdated Show resolved Hide resolved
src/predictions/profiles_mlcorelib/py_native/id_stitcher/cluster_report.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpatchigolla dpatchigolla Awaiting requested review from dpatchigolla

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joker2411 @dpatchigolla