Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: tutorial model #541

Merged
merged 14 commits into from
Jan 23, 2025
Merged

feat: tutorial model #541

merged 14 commits into from
Jan 23, 2025

Conversation

shubhammehra4
Copy link
Contributor

Description of the change

Final PR for all tutorial changes to be merged before 0.7.0 release

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

* fix: output_type for tutorial

* fix: update audit and propensity

* chore: add run type interactive
@shubhammehra4 shubhammehra4 added DO NOT MERGE Approved but need to check more v0.7.0 This label signifies PRs to be merged before 0.7.0 release labels Dec 24, 2024
@shubhammehra4 shubhammehra4 changed the title fix: output_type for tutorial (#525) feat: tutorial model Dec 24, 2024
shubhammehra4 and others added 13 commits December 24, 2024 12:40
* feat: add features and feature_view

* chore: add options & default to id_types

* chore: remove id_list

* chore: update sample data for redshift

* fix: redshift and macro

* fix: bq table name

* fix: bq changes

* chore: update sample data
* chore: tutorial integration test

* chore: include pexpect in requirements

* Fixed a couple of bugs
1. On snowflake, the table name is coming in lower case which is causing an issue downstream
2. If sample_data gets some updates, that is not being reflected if older sample_data was already present. Always re-creating the sample_data

---------

Co-authored-by: dpatchigolla <[email protected]>
Co-authored-by: Dileep Patchigolla <[email protected]>
@dpatchigolla dpatchigolla merged commit 7fad648 into main Jan 23, 2025
11 checks passed
@dpatchigolla dpatchigolla deleted the feat.tutorialModel branch January 23, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Approved but need to check more v0.7.0 This label signifies PRs to be merged before 0.7.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants