feat: add dialect#normaliseidentifier and dialect#parserelationref #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atzoum
force-pushed
the
feat.dialectIdentifiers
branch
2 times, most recently
from
034a1bb to
11f9eb1
Compare
atzoum
requested review from
AchuthaSourabhC,
RanjeetMishra,
sprksh,
vyeshwanth,
ruchiramoitra,
kuldeep0020,
Vikas26021999,
gbreahna,
SumanthPuram and
achettyiitr
atzoum
force-pushed
the
feat.dialectIdentifiers
branch
from
11f9eb1 to
42499ba
Compare
atzoum
force-pushed
the
feat.dialectIdentifiers
branch
2 times, most recently
from
31f8ac6 to
27d16d3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
==========================================
+ Coverage 85.60% 85.89% +0.29%
==========================================
Files 75 75
Lines 3098 3176 +78
==========================================
+ Hits 2652 2728 +76
- Misses 293 295 +2
Partials 153 153 ☔ View full report in Codecov by Sentry. |
atzoum
force-pushed
the
feat.dialectIdentifiers
branch
3 times, most recently
from
0f3f6a5 to
af772c4
Compare
atzoum
force-pushed
the
feat.dialectIdentifiers
branch
4 times, most recently
from
5738ba7 to
098fe92
Compare
atzoum
force-pushed
the
feat.dialectIdentifiers
branch
from
098fe92 to
ca468c0
Compare
Merged
atzoum
pushed a commit
that referenced
this pull request
Jul 22, 2024
🤖 I have created a release *beep* *boop* --- ## [1.7.0](v1.6.0...v1.7.0) (2024-07-22) ### Features * add dialect#normaliseidentifier and dialect#parserelationref ([#120](#120)) ([31d700d](31d700d)) * **redshift:** add support for assuming an iam role for redshift ([#132](#132)) ([180a706](180a706)) * **redshift:** bump github.com/aws/aws-sdk-go-v2/service/redshiftdata from 1.27.1 to 1.27.3 ([#137](#137)) ([ec10cc4](ec10cc4)) ### Miscellaneous * additional params for databricks driver ([#133](#133)) ([9c34f3f](9c34f3f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dialect#NormaliseIdentifier: normalises the identifier's parts that are unquoted, typically by lower or upper casing them, depending on the database.Dialect#ParseRelationRef: parses a string into aRelationRefafter normalising the identifier and stripping out surrounding quotes. The result is aRelationRefwith case-sensitive fields, i.e. it can be safely re-quoted in full (see [QuoteTable] and, for instance, used for matching against the database's information schema.Dialect#FormatTableNamedue to wrong normalisation behaviour inbigqueryandmysql.Security